Remove non-determinism which is breaking net_tests #8069 #8070

pull EthanHeilman wants to merge 2 commits into bitcoin:master from EthanHeilman:bug changing 1 files +10 −1

EthanHeilman commented at 4:08 PM on May 18, 2016: contributor

If addrmanUncorrupted does not have the same nKey every time it will map addrs to different bucket positions and occasionally cause a collision between two addrs, breaking the test.
EthanHeilman cross-referenced this on May 18, 2016 from issue test_bitcoin and caddrdb_read failures by paveljanik
Remove non-determinism which is breaking net_tests #8069 f4119c6c98
in src/test/net_tests.cpp:None in 99427c71a8 outdated
```
  12 | @@ -13,10 +13,18 @@
  13 |  
  14 |  using namespace std;
  15 |  
  16 | +
```
instagibbs commented at 4:23 PM on May 18, 2016:

extra line
paveljanik commented at 7:44 PM on May 18, 2016: contributor
ACK https://github.com/bitcoin/bitcoin/pull/8070/commits/f4119c6c988ea24a5218aa6bc67e57e47e051547

To reproduce the problem without this change:
```
for i in {1..10000}; do echo $i; ./test_bitcoin --run_test=net_tests || break; done
...
Running 2 test cases...
test/net_tests.cpp:92: error in "caddrdb_read": check addrman1.size() == 3 failed
test/net_tests.cpp:102: error in "caddrdb_read": check addrman2.size() == 3 failed

*** 2 failures detected in test suite "Bitcoin Test Suite"
```
When you are here, please fix s/adddrman/addrman/ here: https://github.com/bitcoin/bitcoin/pull/8070/commits/f4119c6c988ea24a5218aa6bc67e57e47e051547#diff-03fc2f333374fd229824451793c40462R131
Fix typo adddrman to addrman as requested in #8070 2a8b3589b5
laanwj merged this on May 19, 2016
laanwj closed this on May 19, 2016
laanwj referenced this in commit 7771aa57bd on May 19, 2016
laanwj cross-referenced this on May 19, 2016 from issue test_bitcoin failing in travis without log output by laanwj
sdaftuar cross-referenced this on May 20, 2016 from issue [RPC] Expose ancestor/descendant information over RPC by sdaftuar
sickpig referenced this in commit 16969f5d33 on May 2, 2017
sickpig cross-referenced this on May 2, 2017 from issue [ported] Core PR 8070 and PR 7932 by sickpig
dexX7 referenced this in commit a400d26561 on Jun 8, 2017
dexX7 referenced this in commit 2476c64723 on Jun 8, 2017
dexX7 referenced this in commit 3edbe7cc79 on Jun 8, 2017
OlegGirko cross-referenced this on Jul 6, 2017 from issue Backport Bitcoin PR#7696: Fix de-serialization bug where AddrMan is left corrupted by OlegGirko
OlegGirko cross-referenced this on Jul 10, 2017 from issue Backport Bitcoin PR#8070: Remove non-determinism which is breaking net_tests by OlegGirko
codablock referenced this in commit 03e8f777c9 on Sep 16, 2017
codablock referenced this in commit 4bafc7f5ab on Sep 19, 2017
codablock referenced this in commit 8eeaa4f212 on Dec 21, 2017
lateminer referenced this in commit bec58f282f on Nov 11, 2018
random-zebra cross-referenced this on Mar 21, 2020 from issue [Tests] Remove non-determinism which is breaking net_tests by random-zebra
furszy referenced this in commit a5288eca97 on Mar 23, 2020
str4d cross-referenced this on Jun 15, 2021 from issue Remove non-determinism which is breaking net_tests by str4d
zkbot referenced this in commit eb8dac51a8 on Jun 15, 2021
bitcoin locked this on Sep 8, 2021

Contributors

EthanHeilman

instagibbs

paveljanik

Linked (view graph)

#7292 [RPC] Expose ancestor/descendant information over RPC #8069 test_bitcoin and caddrdb_read failures #8071 test_bitcoin failing in travis without log output