[WIP] Wallet: Cache CWalletDB pointer in CWallet to improve performance #8026

pull pstratem wants to merge 6 commits into bitcoin:master from pstratem:2016-05-08-wallet-speed changing 7 files +86 −67

pstratem commented at 3:46 AM on May 9, 2016: contributor

No description provided.
pstratem force-pushed on May 9, 2016
pstratem force-pushed on May 9, 2016
jonasschnelli added the label Wallet on May 9, 2016
pstratem force-pushed on May 9, 2016
pstratem cross-referenced this on May 9, 2016 from issue Increase DEFAULT_KEYPOOL_SIZE to 10000. by pstratem
pstratem force-pushed on May 9, 2016
pstratem force-pushed on May 9, 2016
pstratem force-pushed on May 9, 2016
pstratem force-pushed on May 10, 2016
pstratem force-pushed on May 10, 2016
pstratem force-pushed on May 10, 2016
TheBlueMatt commented at 11:09 PM on May 11, 2016: contributor

Can you fix the tests for this?
pstratem commented at 11:14 PM on May 11, 2016: contributor

@TheBlueMatt I'm not sure whether it's broken or if the tests are broken.
pstratem force-pushed on May 12, 2016
pstratem commented at 12:54 AM on May 12, 2016: contributor

Indeed all the tests pass except for the tests which fail on master #8045
pstratem force-pushed on May 12, 2016
pstratem force-pushed on May 12, 2016
pstratem force-pushed on May 12, 2016
pstratem force-pushed on May 12, 2016
pstratem force-pushed on May 12, 2016
pstratem force-pushed on May 12, 2016
MarcoFalke commented at 10:53 AM on May 12, 2016: member

@pstratem The backupwallet rpc appears to be no longer working
pstratem force-pushed on May 14, 2016
Replace pwalletdbEncryption with pwalletdb. ae66aeb669
Use pwalletdb in CWallet::IncOrderPosNext 577192c65c
Move CWallet::AddToWallet to use CWallet::pwalletdb ea26ca76ab
Move CWallet::AddAccountingEntry to use CWallet::pwalletdb 2e93924166
Move CWallet::SetMinVersion to use CWallet::pwalletdb cd86a710fe
pstratem force-pushed on May 14, 2016
Prevent deadlock in BackupWallet. 85a02715c5

in src/wallet/wallet.h:None in ae66aeb669 outdated

 622 | +        pwalletdb = new CWalletDB(strWalletFile, "cr+");
 623 | +    }
 624 | +
 625 | +    void CloseDB()
 626 | +    {
 627 | +        if (pwalletdb) {

sipa commented at 4:13 AM on May 15, 2016:

The conditional is unneeded: deleting NULL is defined to be a nop.

pstratem commented at 11:06 PM on May 16, 2016: contributor

Going to reorganize these changes
pstratem closed this on May 16, 2016
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6966 [WIP] Wallet: Cache CWalletDB pointer in CWallet to improve performance #8025 Increase DEFAULT_KEYPOOL_SIZE to 10000.#8045 WalletBackupTest Fails on Master but Travis Shows as Passing