No description provided.
bitcoin-cli.cpp: Use symbolic constant for exit code #7989
pull tuladhar wants to merge 1 commits into bitcoin:master from tuladhar:patch-2 changing 1 files +1 −1-
tuladhar commented at 4:48 PM on May 2, 2016: contributor
-
bitcoin-cli.cpp: Use symbolic constant for exit code 9a8a7d0115
- tuladhar cross-referenced this on May 2, 2016 from issue Refactor bitcoin-cli.cpp by tuladhar
-
paveljanik commented at 6:01 PM on May 2, 2016: contributor
Looks much better, ACK https://github.com/bitcoin/bitcoin/pull/7989/commits/9a8a7d011564c43231d16e6e3a25c73f0c76fde1
No need to open new PR next time :-)
- MarcoFalke added the label Refactoring on May 3, 2016
-
laanwj commented at 9:33 AM on May 4, 2016: member
- laanwj merged this on May 4, 2016
- laanwj closed this on May 4, 2016
- laanwj referenced this in commit da46f9fd66 on May 4, 2016
-
MarcoFalke commented at 9:40 AM on May 4, 2016: member
I think the motivation for this change was https://stackoverflow.com/questions/461449/return-statement-vs-exit-in-main , so the commit message would be still "wrong".
But the code looks good. utACK 9a8a7d0
-
laanwj commented at 9:44 AM on May 4, 2016: member
It's no less wrong or right, IMO, but it harmonizes the function a bit - all of the other exits from main() use return EXIT_FAILURE.
- tuladhar deleted the branch on May 4, 2016
-
- tuladhar restored the branch on Oct 2, 2016
- str4d cross-referenced this on Mar 14, 2018 from issue CLI binary improvements by str4d
- zkbot referenced this in commit 3b0a5bcd24 on Apr 13, 2018
- zkbot referenced this in commit 65a8f9f201 on Apr 13, 2018
- bitcoin locked this on Sep 8, 2021
Contributors
Labels