Changed in version 3.4: The strict parameter was removed. HTTP 0.9-style “Simple Responses” are not longer supported. (https://docs.python.org/3/library/http.client.html)
Work around this by using a named parameter.
Also avoid an infinite loop in encoding, by ensuring EncodeDecimal returns a string. round(Decimal) used to convert it to float, but it no longer does. Strings are supported since #6380, so just use that.
95 | @@ -96,7 +96,7 @@ def __init__(self, service_url, service_name=None, timeout=HTTP_TIMEOUT, connect 96 | timeout) 97 | else: 98 | self.__conn = httplib.HTTPConnection(self.__url.hostname, port, 99 | - False, timeout) 100 | + timeout=timeout)
Thanks!
This is a bugfix, which should also go upstream?
Yes, probably. Although the EncodeDecimal change does break compatibility with older versions of bitcoind.
Sure, so I'd prefer those to be two commits :)
Actually this was already fixed: https://github.com/jgarzik/python-bitcoinrpc/commit/7ebeebb4f61917fe590d980cb4f9aefdce2c8f25
But somehow we forgot to fetch it.
@MarcoFalke Ok, split into two commits
Tested ACK 28b1ec3
utACK
Travis fail was unrelated (#7470), retriggered.
Avoid an infinite loop in encoding, by ensuring EncodeDecimal
returns a string. round(Decimal) used to convert it to
float, but it no longer does in python 3.x. Strings are
supported since #6380, so just use that.
Changed in version 3.4: The strict parameter was removed. HTTP 0.9-style
“Simple Responses” are not longer supported.
(https://docs.python.org/3/library/http.client.html)
Source: https://github.com/jgarzik/python-bitcoinrpc/commit/7ebeebb4f61917fe590d980cb4f9aefdce2c8f25
utACK e7e48ba