Remove priority estimation #7730

pull morcos wants to merge 3 commits into bitcoin:master from morcos:removePriEst changing 6 files +110 −251
  1. morcos commented at 5:34 PM on March 21, 2016: member

    This removes the functionality behind estimatepriority and estimatesmartpriority. The rpc calls are now deprecated. estimatepriority will return -1 always and estimatesmartpriority will return 1e24 if the mempool is currently limited and -1 otherwise. The result of this behavior is that free transactions (if selected using the now debug option -sendfreetransactions) can be created and sent if the mempool is not currently limited and the transaction's priority is above the hard coded AllowFree threshold.

    This is effectively the behavior in place already as priority estimates do not appear until confirmation targets over 50 which aren't currently supported.

    A side effect of this is that now all transactions (that aren't dependent on unformed inputs) are now considered data points for fee estimation. Even though some transactions may be mined due to their priority instead of fee, this is still safe because the threshold for fee estimation is very high (95%).

  2. morcos force-pushed on Mar 21, 2016
  3. dcousens commented at 1:45 AM on March 22, 2016: contributor

    concept ACK

  4. luke-jr commented at 2:54 AM on March 22, 2016: member

    So this essentially changes priority from "fully supported for usage" to "fallback only", at least from the perspective of Core's wallet. Concept ACK.

  5. jonasschnelli added the label TX fees and policy on Mar 22, 2016
  6. morcos force-pushed on Mar 22, 2016
  7. morcos cross-referenced this on Mar 30, 2016 from issue Clarify outdated text in comment by RHavar
  9. TheBlueMatt commented at 12:59 AM on May 9, 2016: contributor

    Concept ACK, would be good to see this rebased.

  10. MarcoFalke commented at 7:03 AM on May 9, 2016: member

    Concept ACK

  11. sipa commented at 7:31 PM on May 9, 2016: member

    Needs rebase.

  12. morcos force-pushed on May 18, 2016
  13. morcos commented at 7:05 PM on May 18, 2016: member

    trivial rebase

  14. morcos force-pushed on May 19, 2016
  16. in src/policy/fees.cpp:None in 9a936e3909 outdated 
     490 |      int nFileBestSeenHeight;
 491 |      filein >> nFileBestSeenHeight;
 492 |      feeStats.Read(filein);
 493 | -    priStats.Read(filein);
 494 |      nBestSeenHeight = nFileBestSeenHeight;
 495 | +    if (nVersionRequired < 129900) {
    MarcoFalke commented at 10:48 AM on May 20, 2016:

    nit: could be a const.

    MarcoFalke commented at 6:10 PM on September 30, 2016:

    Also needs bump

  17. in src/policy/fees.cpp:None in 9a936e3909 outdated 
     164 | @@ -166,8 +165,8 @@ double TxConfirmStats::EstimateMedianVal(int confTarget, double sufficientTxVal,
 165 |          }
 166 |      }
 167 |  
 168 | -    LogPrint("estimatefee", "%3d: For conf success %s %4.2f need %s %s: %12.5g from buckets %8g - %8g  Cur Bucket stats %6.2f%%  %8.1f/(%.1f+%d mempool)\n",
    MarcoFalke commented at 10:49 AM on May 20, 2016:

    nit: (unrelated to this pull)

    I think estimatefee is missing from debugCategories.

  18. MarcoFalke commented at 10:49 AM on May 20, 2016: member

    utACK 9a936e3

  19. MarcoFalke cross-referenced this on May 20, 2016 from issue Travis sometimes misses commits/pulls by MarcoFalke
  20. sipa commented at 11:55 AM on August 18, 2016: member

    Rebase please?

  21. in src/test/policyestimator_tests.cpp:None in 9a936e3909 outdated 
     166 |                  tx.vin[0].prevout.n = 10000*blocknum+100*j+k;
 167 |                  uint256 hash = tx.GetHash();
 168 | -                mpool.addUnchecked(hash, entry.Fee(feeV[k/4][j]).Time(GetTime()).Priority(priV[k/4][j]).Height(blocknum).FromTx(tx, &mpool));
 169 | +                mpool.addUnchecked(hash, entry.Fee(feeV[j]).Time(GetTime()).Priority(0).Height(blocknum).FromTx(tx, &mpool));
 170 |                  CTransaction btx;
 171 |                  if (mpool.lookup(hash, btx))
    MarcoFalke commented at 5:44 PM on September 30, 2016:

    Needs merge conflict solved here due to 288d85ddf2e0a0c9d25a23db56052883170466d0

  22. sipa commented at 7:16 PM on October 31, 2016: member

    Do we want this for 0.14?

  23. Remove priority estimation 70e1dbecd2
  24. SQUASHME: slight correction to file versioning aacda2276b
  25. morcos force-pushed on Nov 4, 2016
  26. morcos commented at 3:54 PM on November 4, 2016: member

    Sorry for the delay.. I rebased including bumping the version numbers, and I just wanted to flag another minor change I made since the previous version had been acked. This seems like the correct way to handle reading old version files.

  27. add release notes for removal of priority estimation 9ea4ed9977
  28. morcos force-pushed on Nov 4, 2016
  29. MarcoFalke commented at 9:43 AM on November 5, 2016: member

    utACK 9ea4ed9.

    Mind to reword or squash the "SQUASHME" commit?

  30. MarcoFalke added this to the milestone 0.14.0 on Nov 5, 2016
  31. laanwj referenced this in commit 3c03dc2cfc on Nov 7, 2016
  32. laanwj commented at 12:38 PM on November 7, 2016: member

    Merged (and squashed) via 3c03dc2

  33. laanwj closed this on Nov 7, 2016
  34. dooglus cross-referenced this on Nov 8, 2016 from issue fee estimation: UNLIKELY_PCT is declared but never used by dooglus
  35. fanquake cross-referenced this on Nov 9, 2016 from issue Remove unused variable UNLIKELY_PCT from fees.h by fanquake
  36. morcos cross-referenced this on Nov 14, 2016 from issue Removal of "free transaction" logic from codebase by Leviathn
  37. jonathancross cross-referenced this on Dec 3, 2016 from issue Remove TX priority and free transaction area from mempool, block creator by jgarzik
  38. sipa cross-referenced this on Jan 10, 2017 from issue TODO for release notes 0.14.0 by laanwj
  39. codablock referenced this in commit 6eaafa86b6 on Jan 13, 2018
  40. dagurval cross-referenced this on Jun 19, 2018 from issue Remove estimate priority by dagurval
  41. andvgal referenced this in commit f324c4e8f6 on Jan 6, 2019
  42. CryptoCentric referenced this in commit fa60a126b2 on Feb 15, 2019
  43. random-zebra cross-referenced this on Aug 4, 2020 from issue Improve usage of fee estimation code by furszy
  44. random-zebra cross-referenced this on Aug 4, 2020 from issue [Core] Remove priority estimation by random-zebra
  45. random-zebra referenced this in commit 823ba8e334 on Aug 23, 2020
  46. bitcoin locked this on Sep 8, 2021
Contributors
morcosdcousensluke-jrpetertoddTheBlueMattMarcoFalkesipalaanwj
Labels
TX fees and policy

Milestone
0.14.0

Linked (view graph)
#6675 Remove TX priority and free transaction area from mempool, block creator#7768 Clarify outdated text in comment#8455 TODO for release notes 0.14.0#9104 fee estimation: UNLIKELY_PCT is declared but never used#9111 Remove unused variable UNLIKELY_PCT from fees.h#9158 Removal of "free transaction" logic from codebase
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC