[build-aux] Update Boost & check macros to latest serials #7711

1. 
   fanquake commented at 2:16 AM on March 18, 2016: member

   No description provided.

2. jonasschnelli added the label Build system on Mar 18, 2016
3. 
   jonasschnelli commented at 7:22 AM on March 18, 2016: contributor

   LGTM. ping @theuni

4. 
   theuni commented at 8:33 PM on March 18, 2016: member

   @fanquake: Looks like this drops our libsubdirs boost patch (which I thought made it upstream). Was that intentional?

5. [build-aux] Update Boost & check macros to latest serials cf5c786fc3
6. fanquake force-pushed on Mar 19, 2016
7. 
   fanquake commented at 7:24 AM on March 19, 2016: member

   @theuni no, my mistake. The only patch of yours I can see being merged into Boost base was in serial 22.

   This patch hasn't yet made it upstream.

       dnl some arches may advertise a cpu type that doesn't line up with their
       dnl prefix's cpu type. For example, uname may report armv7l while libs are
       dnl installed to /usr/lib/arm-linux-gnueabihf. Try getting the compiler's
       dnl value for an extra chance of finding the correct path.
       libsubdirs="lib/`$CXX -dumpmachine 2>/dev/null` $libsubdirs"
   

8. 
   laanwj commented at 9:48 AM on March 23, 2016: member

   Is this ready for merge? (e.g. all patches are included now?)

9. laanwj cross-referenced this on Mar 31, 2016 from issue [WIP] New ax_pthread.m4 from upstream - draft 3 (not final), for testing on all platforms by paveljanik
10. laanwj assigned theuni on Mar 31, 2016
11. 
    paveljanik commented at 1:31 PM on March 31, 2016: contributor

    Fixes #5516.

    configure output differences here (OS X: master->#7711):

    Expected:

    -checking if compiler needs -Werror to reject unknown flags... yes
    -checking whether pthreads work with -pthread... yes
    +checking whether gcc is Clang... yes
    +checking whether Clang needs flag to prevent "argument unused" warning when linking with -pthread... -Qunused-arguments
    

    Unexpected:

    -checking for __attribute__((visibility))... yes
    +checking for __attribute__((visibility))... no
    

    ACK https://github.com/bitcoin/bitcoin/pull/7711/commits/cf5c786fc3244b6aedcc4a2f839f5248f95fafa1

12. laanwj merged this on Apr 2, 2016
13. laanwj closed this on Apr 2, 2016

    ---

14. laanwj referenced this in commit a67bc5e128 on Apr 2, 2016
15. laanwj added the label Needs backport on Apr 2, 2016
16. 
    theuni commented at 7:11 AM on April 2, 2016: member

    Mm, I missed this before merge. @paveljanik to clarify, are you saying that after this change, the visibility attribute isn't found? If so, that'll be quite ugly at link time. I would think it would cause a flood of "visibility doesn't match" warnings.

17. 
    paveljanik commented at 8:18 AM on April 2, 2016: contributor

    No such warnings here...

18. 
    paveljanik commented at 8:28 AM on April 2, 2016: contributor

    config.log here:

    configure:20859: checking for __attribute__((visibility))
    configure:20883: g++ -o conftest -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -isystem /opt/local/include -I/opt/local/include/db48 -DMAC_OSX  -Wl,-headerpad_max_install_names conftest.cpp  -L/opt/local/lib -L/opt/local/lib/db48 >&5
    conftest.cpp:30:56: warning: target does not support 'protected' visibility; using 'default' [-Wunsupported-visibility]
                        int foo_pro( void ) __attribute__((visibility("protected")));
                                                           ^
    1 warning generated.
    configure:20883: $? = 0
    configure:20896: result: no
    

19. 
    laanwj commented at 9:02 AM on April 2, 2016: member

    Must be due to this change:

                    [visibility], [
                         int foo_def( void ) __attribute__(($1("default")));
                         int foo_hid( void ) __attribute__(($1("hidden")));
    +                    int foo_int( void ) __attribute__(($1("internal")));
    +                    int foo_pro( void ) __attribute__(($1("protected")));
                     ],
    

    Apparently it needs all kinds of visibility to be supported for that check.

    Still fine on ubuntu 14.04:

    configure:20274: checking for __attribute__((visibility))
    configure:20298: g++ -o conftest -g -O2 -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -Wno-self-assign  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS  conftest.cpp  >&5
    configure:20298: $? = 0
    configure:20311: result: yes
    

    That's kind of annoying as we don't use 'protected' visibility at all, as far as I know.

20. fanquake deleted the branch on May 12, 2016
21. rebroad cross-referenced this on Sep 21, 2016 from issue C++11 with gitian support by dgenr8
22. laanwj removed the label Needs backport on Sep 26, 2016
23. laanwj added the label Needs backport on Sep 26, 2016
24. laanwj added this to the milestone 0.12.2 on Sep 26, 2016
25. codablock referenced this in commit 1091bf89f0 on Sep 16, 2017
26. codablock referenced this in commit ec2e86705d on Sep 19, 2017
27. schinzelh cross-referenced this on Oct 23, 2017 from issue [WIP] Update build system to Bitcoin 0.13.2 by schinzelh
28. str4d cross-referenced this on Oct 29, 2017 from issue Darwin build fixes by str4d
29. zkbot referenced this in commit 33f7145fb2 on Nov 29, 2017
30. zkbot referenced this in commit b2399c1951 on Nov 30, 2017
31. zkbot referenced this in commit d3ca2706a8 on Nov 30, 2017
32. zkbot referenced this in commit 02c4467cb5 on Nov 30, 2017
33. codablock referenced this in commit ee408484b4 on Dec 9, 2017
34. codablock referenced this in commit 8e7a7a8b7f on Dec 19, 2017
35. codablock referenced this in commit a5505e7e8c on Dec 19, 2017
36. fanquake removed the label Needs backport on Mar 7, 2018
37. fanquake cross-referenced this on Jul 15, 2020 from issue build: fix building libconsensus with reduced exports for Darwin targets by fanquake
38. bitcoin locked this on Sep 8, 2021

Contributors

fanquakejonasschnellitheunilaanwjpaveljanik

Milestone
0.12.branch