Use system univalue by default #7485

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:sys_univalue_def changing 2 files +4 −4

luke-jr commented at 9:57 PM on February 8, 2016: member

For future merging
Use system univalue by default f587fd51f1
laanwj commented at 10:39 PM on February 8, 2016: member

Previous discussion was in #7349, where it was decided not to automatically use an installed univalue in favor of the included one.
luke-jr commented at 11:01 PM on February 8, 2016: member

...for now.
dcousens commented at 3:44 AM on February 9, 2016: contributor

Why would you opt for system default? Out of interest.
luke-jr commented at 3:48 AM on February 9, 2016: member

Standard best practices. Libraries shouldn't be bundled at all. We have a reasonable case for bundling consensus-critical ones like LevelDB and libsecp256k1, but Univalue is not consensus-critical at all.
laanwj added the label Build system on Feb 10, 2016
laanwj commented at 3:54 PM on April 1, 2016: member

We're not going to do this (at least for the forseeable future), so closing for now.
laanwj closed this on Apr 1, 2016
MarcoFalke cross-referenced this on Jul 8, 2021 from issue Bugfix: Workaround UniValue push_back(bool) limitation with push_back(UniValue(bool)) by luke-jr
bitcoin locked this on Sep 8, 2021

Contributors

Labels