[devtools] github-merge get toplevel dir without extra whitespace #7402

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:dev-tool-fix changing 1 files +1 −1

achow101 commented at 3:46 PM on January 23, 2016: member

Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.
achow101 cross-referenced this on Jan 23, 2016 from issue devtools: show pull and commit information in github-merge by laanwj
jonasschnelli added the label Dev Scripts on Jan 24, 2016
laanwj commented at 1:57 PM on January 25, 2016: member

utACK
laanwj commented at 2:00 PM on January 25, 2016: member
Nit about commit message: please use the
```
Ttitle line
(empty line)
Description...
```
format. Otherwise everything ends up in the subject line, when viewing in git log short format (as used by #7395).

[devtools] github-merge get toplevel dir without extra whitespace

Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.

5ed2f16480

achow101 force-pushed on Jan 25, 2016
achow101 commented at 2:09 PM on January 25, 2016: member

@laanwj fixed that and force pushed
laanwj merged this on Jan 25, 2016
laanwj closed this on Jan 25, 2016
laanwj referenced this in commit 6a5932bf2a on Jan 25, 2016
achow101 deleted the branch on Jan 25, 2016
codablock referenced this in commit 84dd021411 on Sep 16, 2017
codablock referenced this in commit 4a393cb431 on Sep 19, 2017
codablock referenced this in commit c6f8959184 on Dec 9, 2017
codablock referenced this in commit 577f683c5b on Dec 9, 2017
bitcoin locked this on Sep 8, 2021

Contributors

Labels