salvagewallet drops valid keys #7379

issue MarcoFalke opened this issue on January 19, 2016

MarcoFalke commented at 5:54 PM on January 19, 2016: member
Need to look into this next week but I will disable the check in travis in the meantime.
```
check -salvagewallet
Assertion failed: [Decimal('33.99911140'), Decimal('5549.99796160'), Decimal('65.99974900')] != [Decimal('0E-8'), Decimal('5549.99796160'), Decimal('65.99974900')]
```
Edit: Will submit a proper fix tomorrow...
MarcoFalke cross-referenced this on Jan 19, 2016 from issue [qa] Disable salvagewallet check by MarcoFalke
jonasschnelli added the label Bug on Jan 20, 2016
jonasschnelli added the label Wallet on Jan 20, 2016
laanwj cross-referenced this on Jan 20, 2016 from issue [walletdb] Fix syntax error in key parser by MarcoFalke
laanwj commented at 12:47 PM on January 22, 2016: member

"Hopefully" fixed by #7381

laanwj commented at 9:14 AM on February 5, 2016: member

Another intermittent problem in salvagewallet, from https://travis-ci.org/bitcoin/bitcoin/jobs/107074798

check -salvagewallet
start_node: bitcoind started, calling bitcoin-cli -rpcwait getblockcount
start_node: calling bitcoin-cli -rpcwait getblockcount returned
start_node: bitcoind started, calling bitcoin-cli -rpcwait getblockcount
start_node: calling bitcoin-cli -rpcwait getblockcount returned
start_node: bitcoind started, calling bitcoin-cli -rpcwait getblockcount
start_node: calling bitcoin-cli -rpcwait getblockcount returned
Assertion failed: [Decimal('33.99911140'), Decimal('5549.99796180'), Decimal('59.99974800')] != [Decimal('0E-8'), Decimal('5549.99796180'), Decimal('59.99974800')]
  File "/home/travis/build/bitcoin/bitcoin/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/test_framework/test_framework.py", line 135, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/wallet.py", line 274, in run_test
    assert_equal(balance_nodes, [self.nodes[i].getbalance() for i in range(3)])
  File "/home/travis/build/bitcoin/bitcoin/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/test_framework/util.py", line 415, in assert_equal
    raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
Stopping nodes
Cleaning up
Failed

MarcoFalke commented at 8:14 PM on February 5, 2016: member

I am aware of that. Need to look into this soon™
laanwj referenced this in commit 85695802e2 on Feb 15, 2016
laanwj cross-referenced this on Feb 15, 2016 from issue wallet: Warn on unexpected EOF while salvaging wallet by laanwj
laanwj referenced this in commit ca8fb59ae1 on Feb 15, 2016
MarcoFalke referenced this in commit fa3fafc960 on Apr 12, 2016
MarcoFalke cross-referenced this on Jul 3, 2016 from issue bitcoin-core error (file:wallet/crypter.cpp,line 190) by areur3ady
UdjinM6 referenced this in commit d6f3ae95db on May 30, 2017
jnewbery cross-referenced this on Jun 6, 2017 from issue [WIP] Salvage wallet should not set the aggressive flag on Db::verify() by jnewbery
lateminer referenced this in commit 289e2f80b4 on Jan 7, 2018
MarcoFalke cross-referenced this on May 9, 2020 from issue wallet: Move salvagewallet into wallettool by achow101
MarcoFalke cross-referenced this on May 22, 2020 from issue Sqlite wallet storage by Sjors
furszy referenced this in commit 89cc1c454b on Oct 26, 2020
furszy referenced this in commit 11c17eb18b on Oct 28, 2020
furszy referenced this in commit 680f6fb18c on Nov 6, 2020
furszy referenced this in commit 6a0c59af25 on Nov 11, 2020
adamjonas commented at 12:02 AM on July 26, 2022: member

-salvagewallet was removed in #18918
adamjonas closed this on Jul 26, 2022
bitcoin locked this on Jul 26, 2023

Contributors

Labels

Linked (view graph)

#7380 [qa] Disable salvagewallet check #7381 [walletdb] Fix syntax error in key parser #7537 wallet: Warn on unexpected EOF while salvaging wallet #8300 bitcoin-core error (file:wallet/crypter.cpp,line 190)#10540 [WIP] Salvage wallet should not set the aggressive flag on Db::verify()#18916 Sqlite wallet storage #18918 wallet: Move salvagewallet into wallettool