It causes occasional deadlocks, resulting in false negatives in Travis.
Disable the test for now. Works around #6540.
test: Disable scheduler test manythreads #7144
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_12_disable_schedulertest changing 1 files +2 −0-
laanwj commented at 1:57 PM on December 1, 2015: member
-
8f0d79e3c8
test: Disable scheduler test manythreads
It causes occasional deadlocks, resulting in false negatives in Travis. Disable the test for now. Works around #6540.
- laanwj added the label Tests on Dec 1, 2015
- laanwj cross-referenced this on Dec 1, 2015 from issue scheduler_tests (currently disabled) occasionally deadlocks by posita
-
sipa commented at 8:09 PM on December 1, 2015: member
ACK. We don't use multiple thread scheduling anyway, I think?
-
gavinandresen commented at 8:30 PM on December 1, 2015: contributor
ACK-- we use a single scheduler thread.
-
MarcoFalke commented at 9:44 PM on December 1, 2015: member
Then why not remove/rewrite the code instead of putting a comment around it?
-
jonasschnelli commented at 6:53 AM on December 2, 2015: contributor
ACK
-
laanwj commented at 9:15 AM on December 2, 2015: member
Then why not remove/rewrite the code instead of putting a comment around it?
This is a temporary measure (that's why it says "for now" everywhere). Obviously actually fixing the code would be preferable, but in all the time #6540 was open this has not been done - so seemingly non-trivial? Right now in the bustle before the 0.12 branch we don't want to have Travis false negatives interfering.
(edit: I tried to cut this Gordian knot of threads in #6171, but apparently there is still another problem than the one solved there)
- laanwj merged this on Dec 2, 2015
- laanwj closed this on Dec 2, 2015
- laanwj referenced this in commit 1b0241fcec on Dec 2, 2015
- paveljanik cross-referenced this on Dec 4, 2015 from issue [Trivial] Disable compiler warnings about unused functions by paveljanik
- luke-jr referenced this in commit f03d898094 on Dec 8, 2015
- laanwj cross-referenced this on May 5, 2016 from issue Get rid of a compiler warning due to #if 0'd test by avar
- bitcoin locked this on Sep 8, 2021
Contributors
Labels