Replace scriptnum_test's normative ScriptNum implementation #7095

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_11_remove_openssl_consensus_checks changing 4 files +206 −200

laanwj commented at 12:22 PM on November 25, 2015: member

Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL's BN.

Closes #7086.
laanwj added the label Tests on Nov 25, 2015

Replace scriptnum_test's normative ScriptNum implementation

Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes #7086.

4ec3561eb3

laanwj force-pushed on Nov 25, 2015
laanwj commented at 1:00 PM on November 25, 2015: member

Right, I didn't update the makefile at all, should pass now.
theuni commented at 8:00 PM on November 25, 2015: member

ut ACK. I didn't verify that this move-only-ish from 0.10.
dcousens commented at 11:58 PM on November 25, 2015: contributor

concept ACK, once-over utACK ~~, doesn't look like a move only. Functions were [at least] re-ordered hence the rename diff wasn't suppressed.~~
laanwj commented at 6:46 AM on November 26, 2015: member

not a move only

Strange - I copied CScriptNum10 exactly from the 0.10 branch. The only change should be the comment and rename. There should have been no reordering.
laanwj cross-referenced this on Nov 26, 2015 from issue OpenSSL 1.1 - tests* BIGNUM - BN_init -> BN_new by vindicatorr
MarcoFalke commented at 12:12 PM on November 26, 2015: member

Can confirm all the code in https://github.com/laanwj/bitcoin/blob/4ec3561eb3473638230ef780b41343bc6284b460/src/test/scriptnum10.h is taken from the .10 branch.
dcousens commented at 3:32 AM on November 27, 2015: contributor

taken from the .10 branch.

My fault, I was comparing against the current src/test/bignum.h. Striked my comment above.
laanwj merged this on Nov 27, 2015
laanwj closed this on Nov 27, 2015
laanwj referenced this in commit d8368a07ba on Nov 27, 2015
dagurval cross-referenced this on Apr 5, 2018 from issue Replace scriptnum_test's normative ScriptNum implementation by dagurval
str4d cross-referenced this on Apr 30, 2020 from issue Fix undefined behavior in the test_bitcoin tests by defuse
str4d cross-referenced this on Sep 23, 2020 from issue Remove OpenSSL by str4d
zkbot referenced this in commit 5bea6d806f on Sep 23, 2020
zkbot referenced this in commit 8777d2884e on Sep 29, 2020
zkbot referenced this in commit b5fa52b701 on Oct 1, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7086 OpenSSL 1.1 - tests* BIGNUM - BN_init -> BN_new