[qa] rpc-tests: Properly use test framework #7027

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-rpcTestCleanup changing 1 files +57 −106
  1. MarcoFalke commented at 12:25 PM on November 16, 2015: member

    Some tests are not using the framework and thus are blocking some travis related PRs...

    It is best to review this PR commit-by-commit. (Append the ?w=flag to white-space-only commits)

  2. [qa] keypool: Fix white space to prepare transition to test framework c6973ca03b
  3. [qa] keypool: DRY: Use test framework 4ea1790553
  4. jonasschnelli added the label Tests on Nov 16, 2015
  5. MarcoFalke force-pushed on Nov 19, 2015
  6. MarcoFalke commented at 12:20 PM on November 26, 2015: member

    Keypool is from #4347.

    This fixes:

    $ qa/pull-tester/rpc-tests.py keypool --coverage
    Initializing coverage directory at /tmp/coveragerTt3hc
    Running 2nd level testscript keypool.py...
    Usage: keypool.py [options]
    
    keypool.py: error: no such option: --coveragedir
    
  7. sipa commented at 12:57 PM on November 28, 2015: member

    utACK

  8. MarcoFalke commented at 10:41 AM on November 30, 2015: member

    @laanwj any reason you didn't do this as part of #4347?

  9. laanwj commented at 11:12 AM on November 30, 2015: member

    @laanwj any reason you didn't do this as part of #4347?

    Probably didn't know about it yet, or even didn't exist yet when I started working on it.

    utACK anyhow

  10. laanwj merged this on Nov 30, 2015
  11. laanwj closed this on Nov 30, 2015

  12. laanwj referenced this in commit 6fc287f2df on Nov 30, 2015
  13. MarcoFalke deleted the branch on Nov 30, 2015
  14. dagurval cross-referenced this on Sep 2, 2017 from issue keypool test bump + detach wallet from miner by dagurval
  15. str4d cross-referenced this on Nov 20, 2020 from issue Backport migration from rpc-tests.sh to rpc-tests.py by str4d
  16. zkbot referenced this in commit 025bd44543 on Nov 21, 2020
  17. zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
  18. zkbot referenced this in commit c8896f9907 on Dec 2, 2020
  19. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC