[Qt] refactor and optimize proxy settings behavior #7025

pull jonasschnelli wants to merge 2 commits into bitcoin:master from jonasschnelli:2015/11/qt_settingsvalidation changing 4 files +65 −53
  1. jonasschnelli commented at 10:05 AM on November 16, 2015: contributor

    Fixes #6749 and related to #7006.

    This slightly refactors the way how setting a Proxy over the UI settings panel works. It extends and used the QValidatedLineInput class.

    Two goals of this PRs:

    • Setting a invalid proxy should no longer be possible (which could lead to a startup termination)
    • An Invalid proxy get the "red" invalid input-field background (similar like an invalid bitcoin address in the pay-to-address input-field)

    <img width="704" alt="bildschirmfoto 2015-11-16 um 11 01 17" src="https://cloud.githubusercontent.com/assets/178464/11179265/6f5e6ad4-8c52-11e5-9597-aad2a46510a4.png">

  2. [Qt] refactor and optimize proxy settings behavior d16d1b72d1
  3. jonasschnelli added the label GUI on Nov 16, 2015
  4. jonasschnelli commented at 8:55 AM on November 18, 2015: contributor

    Would be nice if someone can test this: Binaries: https://bitcoin.jonasschnelli.ch/pulls/7025/

  5. MarcoFalke commented at 11:39 AM on November 18, 2015: member

    Concept ACK

  6. MarcoFalke commented at 11:39 AM on November 18, 2015: member

    Would be nice if someone can test this

    screenshot from 2015-11-18 12-38-07

  7. [Qt] don't allow to store invalid proxy ports 2a8e8c2e37
  8. jonasschnelli commented at 1:04 PM on November 18, 2015: contributor

    Thanks for testing. There was another possibility to stop bitcoin-qt from starting up: invalid proxy port. Added another commit that protects from storing invalid proxy port ("" or 0).

    New binaries: https://bitcoin.jonasschnelli.ch/pulls/7025/

  9. MarcoFalke commented at 5:21 PM on November 24, 2015: member

    Tested ACK 2a8e8c2

  10. jonasschnelli cross-referenced this on Nov 27, 2015 from issue Qt: Add network port input box to GUI settings by hsjoberg
  11. jonasschnelli merged this on Nov 30, 2015
  12. jonasschnelli closed this on Nov 30, 2015
  13. jonasschnelli referenced this in commit c28d3937b0 on Nov 30, 2015
  14. MarcoFalke cross-referenced this on Jan 27, 2016 from issue [Qt] Unable to open options menu by achow101
  15. jonasschnelli cross-referenced this on Feb 14, 2017 from issue Bugfix: Qt/Options: Restore persistent "restart required" notice by luke-jr
  16. bitcoin locked this on Sep 8, 2021
Contributors
jonasschnelliMarcoFalke
Labels
GUI
Linked (view graph)
#6749 Setting an invalid proxy in GUI settings prevents program from starting#7006 [Qt] add startup option to reset Qt settings#7107 Qt: Add network port input box to GUI settings#7366 [Qt] Unable to open options menu#9755 Bugfix: Qt/Options: Restore persistent "restart required" notice
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC