[tests] rpc tests and travis never fail on asserts #6826

issue MarcoFalke opened this issue on October 14, 2015

MarcoFalke commented at 11:28 AM on October 14, 2015: member

It seems rpc tests and travis no longer fail and silently accept any bug or failing assert.

Steps to reproduce:

$ qa/pull-tester/rpc-tests.py fundrawtransaction;echo $?
Running testscript fundrawtransaction.py...
Initializing test directory /tmp/testCO7ipX
Mining blocks...
Assertion failed: 
  File "/home/marco/workspace/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 118, in main
    self.run_test()
  File "/home/marco/workspace/bitcoin/qa/rpc-tests/fundrawtransaction.py", line 321, in run_test
    assert(feeDelta >= 0 and feeDelta <= feeTolerance)
Stopping nodes
Cleaning up
Failed
0

MarcoFalke cross-referenced this on Oct 14, 2015 from issue [rpc-tests] Check return code by MarcoFalke
laanwj added the label Tests on Oct 20, 2015
laanwj commented at 7:38 AM on October 20, 2015: member

@theuni can you take a look here?
laanwj closed this on Oct 20, 2015
bitcoin locked this on Sep 8, 2021

Contributors

MarcoFalke

laanwj

Labels

Tests

Linked (view graph)

#6827 [rpc-tests] Check return code