Errors in ProcessMessages should not end up in getinfo errors #6809

issue laanwj opened this issue on October 12, 2015

laanwj commented at 8:26 PM on October 12, 2015: member
It's generally harmless if people send corrupted packets, but having the error appear in "errors" makes it look much more serious:
```
"errors" : "EXCEPTION: NSt8ios_base7failureE       \nnon-canonical ReadCompactSize()       \nbitcoin in ProcessMessages()       \n"
```
This happens due to the use of PrintExceptionContinue in the catch clauses, which set strMiscWarning.
laanwj added the label P2P on Oct 12, 2015
laanwj cross-referenced this on Oct 21, 2015 from issue PROCESSMESSAGE: INVALID MESSAGESTART 44version by Rav3nPL
laanwj cross-referenced this on Oct 26, 2015 from issue Clear strMiscWarning before running PartitionAlert by CodeShark
laanwj referenced this in commit 9b63758974 on Nov 27, 2015
laanwj cross-referenced this on Nov 27, 2015 from issue util: Don't set strMiscWarning on every exception by laanwj
laanwj closed this on Nov 27, 2015
napoly cross-referenced this on Dec 11, 2017 from issue util: Don't set strMiscWarning on every exception by napoly
daira referenced this in commit f08e31382b on Feb 21, 2020
daira cross-referenced this on Feb 21, 2020 from issue Upstream PRs relating to strMiscWarning by daira
zkbot referenced this in commit 69e0e7ee62 on Feb 21, 2020
denverbdr referenced this in commit 2c8e5c086f on Mar 6, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels