build: remove libressl check (proposal) #6732

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2015_09_remove_libressl_check changing 2 files +6 −45

laanwj commented at 2:15 PM on September 28, 2015: member

Now that BIP66 passed, OpenSSL is no longer directly part of the consensus. What matters is that DER signatures are correctly parsed, and secp256k1 crypto is implemented correctly (as well as the other functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than using another version of OpenSSL.

Remove the specific check for LibreSSL. This makes it much easier to build on platforms that use LibreSSL by default.

Includes the still-relevant part of #6729: make sure CHECK_HEADER(ec.h) is called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).
laanwj added the label Build system on Sep 28, 2015
laanwj cross-referenced this on Sep 28, 2015 from issue build: set CXXFLAGS for libressl probe by laanwj
laanwj renamed this:
~~build: remove libressl check~~
build: remove libressl check (proposal)
on Sep 29, 2015
laanwj cross-referenced this on Sep 30, 2015 from issue Trivial: start the help texts with lowercase by paveljanik
paveljanik commented at 1:20 PM on September 30, 2015: contributor

ACK
TheBlueMatt commented at 10:20 PM on September 30, 2015: contributor

utACK
theuni commented at 1:56 AM on October 1, 2015: member

ut ACK
jgarzik commented at 9:41 AM on October 1, 2015: contributor

ACK
jgarzik cross-referenced this on Oct 1, 2015 from issue doc: Add build guide for OpenBSD 5.7 by laanwj

build: remove libressl check

Now that BIP66 passed, OpenSSL is no longer directly part of the
consensus. What matters is that DER signatures are correctly parsed, and
secp256k1 crypto is implemented correctly (as well as the other
functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than
using another version of OpenSSL.

Remove the specific check for LibreSSL.

Includes the still-relevant part of #6729: make sure CHECK_HEADER is
called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).

5978388476

doc: no longer require use of openssl in OpenBSD build guide a3874c7c3a
laanwj force-pushed on Oct 1, 2015
laanwj merged this on Oct 1, 2015
laanwj closed this on Oct 1, 2015
laanwj referenced this in commit bb882d04e8 on Oct 1, 2015
luke-jr referenced this in commit 1782cfe9d3 on Jan 9, 2016
luke-jr referenced this in commit ed06991bcf on Jan 10, 2016
MarcoFalke cross-referenced this on Jun 26, 2016 from issue libressl is detected even if openssl is selected on openbsd w/ 0.11 by ChoHag
str4d cross-referenced this on Sep 20, 2016 from issue NCC-2016-007 - Upgrade OpenSSL by daira
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6729 build: set CXXFLAGS for libressl probe #6731 doc: Add build guide for OpenBSD 5.7 #6739 Trivial: start the help texts with lowercase #8269 libressl is detected even if openssl is selected on openbsd w/ 0.11