Replace boost::reverse_lock with our own #6630

pull casey wants to merge 1 commits into bitcoin:master from casey:remove-boost-reverse-lock changing 5 files +100 −2

casey commented at 4:57 PM on September 3, 2015: contributor

See #6608 for discussion.

This removes boost::reverse_lock so that we don't depend on boost 1.50, and replaces it with our own implementation.

This implementation is stricter than boost::reverse_lock. Reverse locking an unlocked lock, and re-locking a lock while a reverse_lock is active are both errors.
casey cross-referenced this on Sep 3, 2015 from issue Fix #6394 without boost dependency. by casey
sipa commented at 5:00 PM on September 3, 2015: member

ACK if Travis is happy.
casey commented at 5:09 PM on September 3, 2015: contributor

Travis is unhappy; I think I neglected to add the new file to the makefile. Fixing it now.
paveljanik commented at 6:02 PM on September 3, 2015: contributor

ACK after minor nits.

in src/reverselock.h:None in 2321bb35c3 outdated

  25 | +private:
  26 | +    reverse_lock(reverse_lock const&);
  27 | +    reverse_lock& operator=(reverse_lock const&);
  28 | +
  29 | +    Lock& lock;
  30 | +    //mutex_type* mutex;

laanwj commented at 6:07 PM on September 3, 2015:

Redundant commented line

casey commented at 7:13 PM on September 3, 2015:

Removed

laanwj commented at 6:08 PM on September 3, 2015: member

utACK, thanks for adding tests!
gavinandresen commented at 6:26 PM on September 3, 2015: contributor

ACK, works nicely on my OSX machine.
Replace boost::reverse_lock with our own. 86270c8164
laanwj merged this on Sep 3, 2015
laanwj closed this on Sep 3, 2015
laanwj referenced this in commit 195942d58e on Sep 3, 2015
laanwj cross-referenced this on Sep 3, 2015 from issue Fix #6394 without boost >=1.50 dependency by pstratem
dcousens commented at 11:52 PM on September 3, 2015: contributor

Great work @casey :+1: , utACK
jonasschnelli commented at 7:21 AM on September 4, 2015: contributor

PostMerge ACK. @casey: Nice work!
bitcoin locked this on Sep 8, 2021

Contributors

Linked (view graph)

#6608 Fix #6394 without boost dependency.#6610 Fix #6394 without boost >=1.50 dependency