This fixes a race condition where the block store or the transaction store might be accessed after being closed. To fix this, we wait until all connections are closed before closing the stores.
This race condition is tricky to trigger, but I hit it when writing an extended block acceptance test.
utACK
169 | + test_node.add_connection(self.connections[-1]) 170 | + 171 | + def wait_for_disconnections(self): 172 | + def disconnected(): 173 | + return all(node.closed for node in self.test_nodes) 174 | + wait_until(disconnected, timeout=10)
Maybe return wait_until so that callers know whether it succeeded or timed out? (same for other wait_for_XXX)
Seems reasonable to me, changed.