Separate core memory usage computation in core_memusage.h #6453

pull sipa wants to merge 1 commits into bitcoin:master from sipa:coremem changing 11 files +76 −99

sipa commented at 5:48 PM on July 17, 2015: member

Remove support for computing recursive memory usage from memusage.h, making it more easy to plug in other functions.

Furthermore, move the computation of memory usage of core data structures from primitives/*, to reduce its dependencies, specifically on boost.

Should fix #6441.
laanwj added the label Refactoring on Jul 17, 2015
sipa cross-referenced this on Jul 17, 2015 from issue Limited mempool + floating relay fee + rejection caching + mempool expiry by sipa

in src/core_memusage.h:None in 1fc0741ddd outdated

  57 | +
  58 | +static inline size_t RecursiveDynamicUsage(const CBlockLocator& locator) {
  59 | +    return memusage::DynamicUsage(locator.vHave);
  60 | +}
  61 | +
  62 | +#endif // BITCOIN_PRIMITIVES_TRANSACTION_H

Diapolo commented at 2:57 PM on July 18, 2015:

Nit: Wrong end comment :).

sipa commented at 3:18 PM on July 20, 2015:

Thanks, fixed!

laanwj commented at 10:28 AM on July 20, 2015: member

utACK, looks like the good solution to me
Separate core memory usage computation in core_memusage.h 9e38d0f745
sipa force-pushed on Jul 20, 2015
laanwj merged this on Jul 20, 2015
laanwj closed this on Jul 20, 2015
laanwj referenced this in commit 8fe5cce3d5 on Jul 20, 2015
str4d cross-referenced this on Mar 14, 2017 from issue Bitcoin 0.12 mempool memory usage PRs by str4d
zkbot referenced this in commit 00e59e5935 on Mar 23, 2017
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6441 Compile error on OSX #6455 Limited mempool + floating relay fee + rejection caching + mempool expiry