qt: define QT_NO_KEYWORDS #6433

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_07_qt_no_keywords changing 66 files +184 −184

laanwj commented at 12:03 PM on July 14, 2015: member

QT_NO_KEYWORDS prevents Qt from defining the foreach, signals, slots and emit macros.

Avoid overlap between Qt macros and boost - for example #undef hackiness in #6421.

The drawback is that all uses of the macros have to be replace by Q_xxx, but at least this is easy to review.

Cc: @sipa @theuni
laanwj added the label Build system on Jul 14, 2015
laanwj added the label GUI on Jul 14, 2015
jonasschnelli commented at 6:55 PM on July 14, 2015: contributor

code-review ACK. Definitively a improvement!
theuni commented at 8:31 PM on July 14, 2015: member

Quick glance utACK. Nice fix. IMO it's more readable this way anyway, since it makes it more obvious to the casual reader that signals/slots are just sugary macros and not some c++ functionality they're not aware of.
sipa commented at 10:34 PM on July 14, 2015: member

utACK

qt: define QT_NO_KEYWORDS

QT_NO_KEYWORDS prevents Qt from defining the `foreach`, `signals`,
`slots` and `emit` macros.

Avoid overlap between Qt macros and boost - for example #undef hackiness
in #6421.

d29ec6c230

laanwj force-pushed on Jul 15, 2015
laanwj commented at 5:37 AM on July 15, 2015: member

Fixed some unmeant changes of emit in sentences to Q_EMIT in comments (but left the ones where it makes sense)
laanwj merged this on Jul 15, 2015
laanwj closed this on Jul 15, 2015
laanwj referenced this in commit 11edb0de5b on Jul 15, 2015
laanwj commented at 6:35 AM on July 15, 2015: member

Should be fairly risk-free to do in older major releases as well in case we want to backport #6421
laanwj commented at 9:14 AM on July 15, 2015: member

Cherry-picked to 0.11 as e092f22951d391a62871ab58abf9c397a656cf03
laanwj referenced this in commit e092f22951 on Jul 15, 2015
laanwj referenced this in commit ce183dce2e on Jul 15, 2015
laanwj referenced this in commit 164966705a on Jul 15, 2015
jonasschnelli cross-referenced this on Jul 24, 2015 from issue [Qt] allow users to set -onion via GUI by Diapolo
zander cross-referenced this on Sep 14, 2015 from issue Add a manager for the messages in the form of informationqueuedialog by zander
MarcoFalke referenced this in commit f5d5131c00 on Mar 26, 2016
Fuzzbawls cross-referenced this on Oct 17, 2019 from issue [Qt] Define QT_NO_KEYWORDS by Fuzzbawls
furszy referenced this in commit 9d259c93c7 on Jan 30, 2020
wqking referenced this in commit 7199219c07 on Jul 29, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#4587 [Qt] allow users to set -onion via GUI #6421 Continuously limit the memory pool memory consumption