Implement watchonly support in fundrawtransaction #6415

pull TheBlueMatt wants to merge 10 commits into bitcoin:master from TheBlueMatt:frt3 changing 22 files +272 −63
  1. TheBlueMatt commented at 5:54 AM on July 10, 2015: contributor

    No description provided.

  2. TheBlueMatt commented at 5:54 AM on July 10, 2015: contributor

    Realized I forgot to submit this after #6088....

  3. sdaftuar cross-referenced this on Jul 10, 2015 from issue Intermittent test failures in fundrawtransaction.py by laanwj
  4. jonasschnelli commented at 6:50 PM on July 14, 2015: contributor

    Needs rebase

  5. laanwj added the label Feature on Jul 17, 2015
  6. TheBlueMatt force-pushed on Jul 17, 2015
  7. TheBlueMatt force-pushed on Jul 17, 2015
  8. Also remove pay-2-pubkey from watch when adding a priv key cfc3dd3428
  9. Split up importaddress into helper functions 983d2d90af
  10. Add p2sh option to importaddress to import redeemScripts 907a425aa5
  11. Add importpubkey method to import a watch-only pubkey a1d7df3236
  12. Update importaddress help to push its use to script-only 5c17059872
  13. Add have-pubkey distinction to ISMINE flags
    This indicates that, eg, we have a public key for a key which may
    be used as a pay-to-pubkey-hash. It generally means that we can
    create a valid scriptSig except for missing private key(s) with
    which to create signatures.
    d3354c52d7
  14. Add logic to track pubkeys as watch-only, not just scripts f5813bdd3e
  15. Implement watchonly support in fundrawtransaction
    Some code and test cases stolen from
    Bryan Bishop <bryan@ledgerx.com> (pull #5524).
    6bdb474dc9
  16. TheBlueMatt force-pushed on Jul 20, 2015
  17. jgarzik commented at 7:11 PM on July 23, 2015: contributor

    ut ACK

  18. SQUASH "Add have-pubkey distinction to ISMINE flags" 428a898acd
  19. SQUASH "Implement watchonly support in fundrawtransaction" d04285430d
  20. sipa commented at 3:03 PM on August 10, 2015: member

    Untested ACK.

  21. sipa commented at 4:13 PM on August 10, 2015: member

    Hmm, do you actually need to have the full CPubKey object available? Just marking a particular key id as "trust me, i can sign this" should be enough, or am i missing something?

  22. sipa commented at 4:44 PM on August 10, 2015: member

    Ignore me, the dummy signer needs it. Nice.

  23. laanwj commented at 2:14 PM on August 14, 2015: member

    utACK

  24. laanwj merged this on Aug 14, 2015
  25. laanwj closed this on Aug 14, 2015

  26. laanwj referenced this in commit ddd8d80c63 on Aug 14, 2015
  27. daira cross-referenced this on Mar 4, 2017 from issue Bitcoin 0.12 RPC PRs 1 by str4d
  28. str4d cross-referenced this on Mar 29, 2017 from issue Bitcoin 0.12 wallet PRs by str4d
  29. dagurval cross-referenced this on Dec 27, 2017 from issue Add fundrawtransaction by dagurval
  30. MarcoFalke cross-referenced this on Apr 25, 2018 from issue [trivial] Correct help text for `importaddress` RPC by jnewbery
  31. daira cross-referenced this on Nov 22, 2018 from issue support for fundrawtransaction with includingWatchOnly outputs by piyush-bittmax
  32. bitcartel referenced this in commit 4c70e15d8c on Apr 2, 2019
  33. str4d cross-referenced this on Nov 14, 2019 from issue Bitcoin 0.12 wallet PRs 1 by str4d
  34. str4d referenced this in commit 5c76b1df64 on Nov 14, 2019
  35. str4d referenced this in commit 7bc673977a on Nov 14, 2019
  36. zkbot referenced this in commit 5e26d48a39 on Dec 3, 2019
  37. str4d referenced this in commit de2eddd21d on Dec 3, 2019
  38. str4d referenced this in commit ebd0669816 on Dec 3, 2019
  39. str4d referenced this in commit 3c8c8009db on Dec 4, 2019
  40. str4d referenced this in commit 82beb18901 on Dec 4, 2019
  41. random-zebra cross-referenced this on Jun 4, 2020 from issue [Wallet][RPC] FundTransaction - fundrawtransaction by random-zebra
  42. furszy referenced this in commit bf132c4e6a on Jun 18, 2020
  43. furszy referenced this in commit fe31b31eec on Jun 18, 2020
  44. furszy referenced this in commit 0724bbbad2 on Jun 28, 2020
  45. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC