Fix intermittent test failure, reduce test time #6414

pull dgenr8 wants to merge 1 commits into bitcoin:master from dgenr8:clone_test_improve changing 2 files +5 −3

dgenr8 commented at 1:32 AM on July 10, 2015: contributor

In txn_clone.py, non-essential test transaction tx2 was asserted to be unconfirmed, but would occasionally confirm depending on network behavior. Fix by explicitly sharing with miner and checking for 1 confirmation.

Reduce required conflict tests from 4 to 2, by moving one invocation each of txn_clone.py and txn_doublespend.py to the extended test section. This saves about 15 seconds per test run for me.

Fix intermittent test failure, reduce test time

In txn_clone.py, non-essential test transaction tx2 was asserted
to be unconfirmed, but would occasionally confirm depending on
network behavior.  Fix by explicitly sharing with miner and
checking for 1 confirmation.

Reduce required conflict tests from 4 to 2, by moving one invocation
each of txn_clone.py and txn_doublespend.py to the extented test
section.  This saves about 15 seconds per test run for me.

8a0b933aae

laanwj added the label Tests on Jul 10, 2015
laanwj commented at 12:15 PM on July 10, 2015: member

utACK
laanwj merged this on Jul 10, 2015
laanwj closed this on Jul 10, 2015
laanwj referenced this in commit 5121c68657 on Jul 10, 2015
laanwj cross-referenced this on Jul 10, 2015 from issue Intermittent test failures in fundrawtransaction.py by laanwj
str4d cross-referenced this on Feb 15, 2017 from issue Bitcoin 0.12 test PRs 1 by str4d
zkbot referenced this in commit 57d420e2f8 on Feb 15, 2017
zkbot referenced this in commit 88c209dba6 on Feb 20, 2017
dagurval cross-referenced this on Jul 3, 2017 from issue Fix intermittent test failure, reduce test time by dagurval
dgenr8 deleted the branch on Sep 19, 2018
bitcoin locked this on Dec 16, 2021

Contributors

dgenr8

laanwj

Labels

Tests

Linked (view graph)

#6391 Intermittent test failures in fundrawtransaction.py