tests: Fix bitcoin-tx signing test case #6390

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_07_fix_bitcointx_test changing 2 files +2 −2

laanwj commented at 4:26 PM on July 7, 2015: member

Fixes wrong scriptPubkey problem in #6389, causing the transaction to not actually be signed.

Also change bitcoin-tx so that in MutateTxSign if SignSignature fails, signing is marked as incomplete. This makes sure that errors in e.g. scriptPubKeys are detected.
laanwj added the label Tests on Jul 7, 2015

tests: Fix bitcoin-tx signing testcase

Fixes wrong scriptPubkey problem, which caused the transaction to
not actually be signed.

133601f6a5

laanwj force-pushed on Jul 7, 2015
jgarzik commented at 4:32 PM on July 7, 2015: contributor
ACK, with comments:
- bitcoin-tx notably does nothing with fComplete.
- a "exit(1) if not completely signed" command line switch would enable tests to notice this sort of failure
laanwj commented at 6:00 PM on July 7, 2015: member

Yes, thinking of it, the change to bitcoin-tx is redundant, even if fComplete was somehow reported.

The VerifyScript later in the iteration will already set fComplete to false if the signing was not successful.

Will remove it.
laanwj force-pushed on Jul 8, 2015
laanwj merged this on Jul 8, 2015
laanwj closed this on Jul 8, 2015
laanwj referenced this in commit 6a73d66883 on Jul 8, 2015
laanwj cross-referenced this on Jul 10, 2015 from issue bitcoin-tx sign testcase wrong by paveljanik
str4d cross-referenced this on Feb 15, 2017 from issue Bitcoin 0.12 test PRs 1 by str4d
zkbot referenced this in commit 57d420e2f8 on Feb 15, 2017
zkbot referenced this in commit 88c209dba6 on Feb 20, 2017
zkbot referenced this in commit dadb1ab74c on Mar 3, 2017
dagurval cross-referenced this on Apr 27, 2018 from issue tests: Fix bitcoin-tx signing testcase by dagurval
bitcoin locked this on Sep 8, 2021

Contributors

Labels