Testing infrastructure: mocktime fixes #6337

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:regtest_mocktime changing 2 files +13 −1
  1. gavinandresen commented at 7:20 PM on June 24, 2015: contributor

    New, undocumented-on-purpose -mocktime=timestamp command-line argument to startup with mocktime set. Needed because time-related blockchain sanity checks are done on startup, before a test has a chance to make a setmocktime RPC call.

    And changed the setmocktime RPC call so calling it will not result in currently connected peers being disconnected due to inactivity timeouts.

  2. Testing infrastructure: mocktime fixes
    New, undocumented-on-purpose -mocktime=timestamp command-line
    argument to startup with mocktime set. Needed because
    time-related blockchain sanity checks are done on startup, before a
    test has a chance to make a setmocktime RPC call.
    
    And changed the setmocktime RPC call so calling it will not result in
    currently connected peers being disconnected due to inactivity timeouts.
    6a4b97e863
  3. laanwj added the label Tests on Jun 25, 2015
  4. laanwj commented at 5:16 AM on June 25, 2015: member

    utACK

  5. paveljanik commented at 5:43 AM on June 25, 2015: contributor

    RPC call setmocktime checks for regtest network, but SetMockTime does not contain such check. When the user adds this argument on !regtest network, mocktime is thus set. Do you want it this way as this is a change to the current status quo where user is not allowed to set mocktime on !regtest networks?

  6. laanwj commented at 6:08 AM on June 25, 2015: member

    @paveljanik Good catch! (though I have no opinion on whether this is a problem - we don't advertise the parameter anyhow)

  7. paveljanik commented at 9:19 AM on June 25, 2015: contributor

    I do not have a problem with this too. ACK

  8. gavinandresen cross-referenced this on Jun 26, 2015 from issue Implementation of BIP 101 : maximum block size increase by gavinandresen
  9. laanwj merged this on Jun 29, 2015
  10. laanwj closed this on Jun 29, 2015

  11. laanwj referenced this in commit 0564c5b795 on Jun 29, 2015
  12. str4d cross-referenced this on Feb 14, 2017 from issue Bitcoin 0.12 test PRs 1 by str4d
  13. zkbot referenced this in commit 57d420e2f8 on Feb 15, 2017
  14. zkbot referenced this in commit 88c209dba6 on Feb 20, 2017
  15. zkbot referenced this in commit dadb1ab74c on Mar 3, 2017
  16. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC