Fix getbalance * 0 #6276

pull dgenr8 wants to merge 1 commits into bitcoin:master from dgenr8:getbalance_fix changing 1 files +2 −2

dgenr8 commented at 9:20 PM on June 12, 2015: contributor

Change "getbalance " not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance \ 0" now works.

Ping @jonasschnelli, @wtogami
wtogami commented at 9:45 PM on June 12, 2015: contributor

Tag for 0.10 and 0.11 branches please.
wtogami cross-referenced this on Jun 12, 2015 from issue Zero conf getbalance regression in Bitcoin 0.10 by wtogami
dgenr8 force-pushed on Jun 12, 2015
dgenr8 force-pushed on Jun 12, 2015

Fix getbalance *

Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

7d6a85ab5b

dgenr8 force-pushed on Jun 12, 2015
jonasschnelli commented at 7:45 AM on June 13, 2015: contributor

utACK. Also utACK backport to 0.10 and 0.11. Because the accounting system has been marked for deprecation, we should slowly start to think about how the deprecation could lead/turn to a removal (or transformation to labels).
thrasher- commented at 8:47 AM on June 13, 2015: none

Tested and works as expected, backporting to 0.10 requires renaming CheckFinalTx to IsFinalTx.
thrasher- cross-referenced this on Jun 14, 2015 from issue Fixed getbalance command by thrasher-
laanwj added the label Wallet on Jun 15, 2015
laanwj commented at 7:02 AM on June 15, 2015: member

utACK
laanwj merged this on Jun 15, 2015
laanwj closed this on Jun 15, 2015
laanwj referenced this in commit f3d4dbb939 on Jun 15, 2015
laanwj referenced this in commit c9fd9078ce on Jun 15, 2015
laanwj referenced this in commit c7d28ce12a on Jun 15, 2015
laanwj commented at 7:16 AM on June 15, 2015: member

Cherry-picked to 0.11 as c9fd9078ced17f6880274b4764736c5a9ab4eddb, to 0.10 as (thanks @thrasher-) c7d28ce12af216a691f7aac1ae48f11c979d604f
laanwj referenced this in commit 1e6449228f on Jun 15, 2015
laanwj referenced this in commit 0fd8464458 on Jun 15, 2015
MarcoFalke cross-referenced this on Feb 28, 2016 from issue 0.12 getbalance behavior by message
dgenr8 deleted the branch on Sep 19, 2018
luke-jr cross-referenced this on Oct 29, 2018 from issue Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr
reddink referenced this in commit e5d9e28a0f on May 27, 2020
bitcoin deleted a comment on Aug 15, 2021
bitcoin locked this on Aug 15, 2021
bitcoin deleted a comment on Aug 15, 2021

Contributors

Labels

Linked (view graph)

#7597 0.12 getbalance behavior #14602 Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*")