If/when CTransaction::CURRENT_VERSION is incremented, this will break CChainParams and the miner tests. This fix sets the transaction version explicitly where we depend on the hash value (genesis block, proof of work checks).
Explicitly set tx.nVersion for the genesis block and mining tests #6222
pull maaku wants to merge 1 commits into bitcoin:master from maaku:explicit-tx-version changing 2 files +2 −0-
maaku commented at 11:40 PM on June 2, 2015: contributor
-
efd44440d8
Explicitly set tx.nVersion for the genesis block and mining tests
If/when CTransaction::CURRENT_VERSION is incremented, this will break CChainParams and the miner tests. This fix sets the transaction version explicitly where we depend on the hash value (genesis block, proof of work checks).
-
luke-jr commented at 1:43 AM on June 3, 2015: member
utACK
-
maaku commented at 1:49 AM on June 3, 2015: contributor
Btw, note for future reference that actually changing CURRENT_VERSION breaks some of the hex test data, but that's not easy to future proof now.
- laanwj added the label Tests on Jun 3, 2015
-
jgarzik commented at 2:36 AM on June 7, 2015: contributor
ut ACK
-
petertodd commented at 4:59 AM on June 7, 2015: contributor
utACK
- laanwj merged this on Jun 10, 2015
- laanwj closed this on Jun 10, 2015
- laanwj referenced this in commit 9c93ee5ceb on Jun 10, 2015
- dagurval cross-referenced this on Mar 14, 2017 from issue Chainparams backports by dagurval
- str4d cross-referenced this on Mar 28, 2017 from issue Bitcoin 0.12 chainparams cleanups by str4d
- zkbot referenced this in commit e1c68f0631 on Jan 19, 2018
- zkbot referenced this in commit 4f77ce5cb1 on Jan 22, 2018
- zkbot referenced this in commit cc571a3ccd on Jan 22, 2018
- zkbot referenced this in commit 50c23880c7 on Jan 22, 2018
- zkbot referenced this in commit a4a020de7b on Jan 22, 2018
- bitcoin locked this on Sep 8, 2021
