To protect privacy, do not use UPNP when a proxy is set. The user may still specify -listen=1 to listen locally (for a hidden service), so don't rely on this happening via the -listen case.
Fixes #2927.
Parameter interaction: disable upnp if -proxy set #6153
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_05_proxy_noupnp changing 1 files +4 −0-
laanwj commented at 9:23 AM on May 18, 2015: member
-
8c35b6f3be
Parameter interaction: disable upnp if -proxy set
To protect privacy, do not use UPNP when a proxy is set. The user may still specify -listen=1 to listen locally (for a hidden service), so don't rely on this happening through -listen. Fixes #2927.
- laanwj cross-referenced this on May 18, 2015 from issue UPNP is not disabled when tor-only settings are in effect. by ghost
- laanwj added the label Bug on May 18, 2015
-
Diapolo commented at 4:18 PM on May 25, 2015: none
You should update the -upnp help message also to e.g.
Use UPnP to map the listening port (default: 1 when listening and no -proxy).utACK, when updated
-
laanwj commented at 5:53 AM on May 26, 2015: member
I'm not going to change the help message for 0.11 (string freeze), but after that feel free to do that.
- laanwj merged this on May 27, 2015
- laanwj closed this on May 27, 2015
- laanwj referenced this in commit 0bcf04f046 on May 27, 2015
- laanwj referenced this in commit ebd7d8d78c on Jun 2, 2015
- reddink referenced this in commit 084db0cb83 on May 27, 2020
- bitcoin locked this on Sep 8, 2021
Labels