tests: Error when setgenerate is used on regtest #6039

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_04_setgenerate_error changing 1 files +2 −0

laanwj commented at 8:20 AM on April 21, 2015: member

Ever since #5957 there has been the problem that older RPC test cases (as can be found plenty in open pulls) use setgenerate() on regtest, assuming a different interpretation of the arguments. Directly generating a number of blocks has been split off into a new method generate - however using setgenerate with the previous arguments will result in spawning an unreasonable number of threads, and well, simply not work as expected without clear indication of the error.

Add an error to point the user at the right method.

tests: Error when setgenerate is used on regtest

Ever since #5957 there has been the problem that older RPC test cases
(as can be found plenty in open pulls) use setgenerate() on regtest,
assuming a different interpretation of the arguments. Directly
generating a number of blocks has been split off into a new method
`generate` - however using `setgenerate` with the previous arguments will
result in spawning an unreasonable number of threads, and well, simply
not work as expected without clear indication of the error.

Add an error to point the user at the right method.

27ce808fb5

jonasschnelli commented at 8:22 AM on April 21, 2015: contributor

utACK.
laanwj added the label Tests on Apr 21, 2015
sipa commented at 11:04 AM on April 21, 2015: member

Concept & code review ACK.
morcos commented at 5:02 PM on April 21, 2015: member

ACK
laanwj merged this on Apr 23, 2015
laanwj closed this on Apr 23, 2015
laanwj referenced this in commit 734f80a5d1 on Apr 23, 2015
jrmrjnck cross-referenced this on Oct 17, 2015 from issue Don't use setgenerate on regtest by jrmrjnck
freewil referenced this in commit 64ada96b5a on Oct 17, 2015
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5957 Several mining-related improvements