On hosts that had spent some time with a failed internet connection their nAttempts penalty was going through the roof (e.g. thousands for all peers) and as a result the connect search was pegging the CPU and failing to get more than a 4 connections after days of running (because it was taking so long per try).
Cap nAttempts penalty at 8 and switch to pow instead of a division loop. #6029
pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:nAttempts_cost changing 1 files +2 −3-
gmaxwell commented at 6:52 PM on April 19, 2015: contributor
-
a784f90c98
Cap nAttempts penalty at 8 and switch to pow instead of a division loop.
On hosts that had spent some time with a failed internet connection their nAttempts penalty was going through the roof (e.g. thousands for all peers) and as a result the connect search was pegging the CPU and failing to get more than a 4 connections after days of running (because it was taking so long per try).
- gmaxwell added this to the milestone 0.10.0 on Apr 19, 2015
- gmaxwell cross-referenced this on Apr 19, 2015 from issue Avoid counting failed connect attempts when probably offline. by gmaxwell
-
laanwj commented at 11:46 AM on April 20, 2015: member
Makes sense, utACK
- laanwj merged this on Apr 20, 2015
- laanwj closed this on Apr 20, 2015
- laanwj referenced this in commit 71900b4426 on Apr 20, 2015
-
laanwj commented at 12:00 PM on April 20, 2015: member
Cherry-picked to 0.10 as 139cd8177be4895f8b4c2befee35030bdf96132
- gmaxwell referenced this in commit 139cd8177b on Apr 20, 2015
- reddink referenced this in commit cc13dbf71c on May 27, 2020
- bitcoin locked this on Sep 8, 2021
Milestone
0.10.0