Alter assumptions in CCoinsViewCache::BatchWrite #5967

pull morcos wants to merge 1 commits into bitcoin:master from morcos:AllowIntermediateFlushes changing 2 files +28 −7

morcos commented at 4:47 PM on April 3, 2015: member

Previously it would break if you flushed a parent cache while there was a child cache referring to it. This change will allow the flushing of parent caches.

It also modifies the unit test to include flushing of intermediate caches.
sdaftuar cross-referenced this on Apr 3, 2015 from issue Add autoprune functionality by sdaftuar
laanwj added the label UTXO Db and Indexes on Apr 8, 2015
morcos closed this on Apr 23, 2015
morcos deleted the branch on Apr 23, 2015
morcos restored the branch on Apr 23, 2015
morcos reopened this on Apr 23, 2015

in src/coins.cpp:None in e4484f476c outdated

 147 | -                    // cache does have (a non-pruned) one. Move the data up, and
 148 | -                    // mark it as fresh (if the grandparent did have it, we
 149 | -                    // would have pulled it in at first GetCoins).
 150 | -                    assert(it->second.flags & CCoinsCacheEntry::FRESH);
 151 | +                // The parent cache does not have an entry, while the child does
 152 | +                // We can ignore it if its both FRESH and pruned in the child

sipa commented at 2:44 PM on April 27, 2015:

Nit: s/its/it's/

sipa commented at 2:45 PM on April 27, 2015: member

Untested ACK, but the unit test should cover it.
gavinandresen cross-referenced this on May 15, 2015 from issue Cache transaction validation successes by sipa
morcos force-pushed on May 18, 2015
morcos force-pushed on May 18, 2015
morcos commented at 3:53 PM on May 18, 2015: member

Needed rebase (nit fixed)
MarcoFalke commented at 10:28 PM on November 10, 2015: member

@morcos This needs an update/rebase?
sipa cross-referenced this on Nov 11, 2015 from issue ModifyNewCoins saves database lookups by morcos
morcos force-pushed on Nov 12, 2015
morcos commented at 2:09 AM on November 12, 2015: member

rebased
sipa commented at 5:41 PM on November 13, 2015: member

Code review & lightly tested ACK.

Alter assumptions in CCoinsViewCache::BatchWrite

Previously it would break if you flushed a parent cache while there was a child cache referring to it.  This change will allow the flushing of parent caches.

072e2f8644

morcos force-pushed on Nov 18, 2015
morcos commented at 5:15 PM on November 18, 2015: member

This was rebased to modify the new unit test added from #6932 as well.
morcos cross-referenced this on Nov 18, 2015 from issue Save last db read by morcos
laanwj merged this on Nov 27, 2015
laanwj closed this on Nov 27, 2015
laanwj referenced this in commit 05d591839f on Nov 27, 2015
morcos cross-referenced this on Dec 2, 2015 from issue Remove UTXO cache entries when the tx they were added for is removed/does not enter mempool by TheBlueMatt
dagurval cross-referenced this on Dec 21, 2017 from issue Alter assumptions in CCoinsViewCache::BatchWrite by dagurval
random-zebra cross-referenced this on Jul 30, 2020 from issue [Core] Alter assumptions in CCoinsViewCache::BatchWrite by random-zebra
random-zebra referenced this in commit 68df9a7d5b on Aug 8, 2020
nuttycom cross-referenced this on Feb 11, 2021 from issue Backport of bitcoin/bitcoin#10195 by nuttycom
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5863 Add autoprune functionality #6077 Cache transaction validation successes #6872 Remove UTXO cache entries when the tx they were added for is removed/does not enter mempool #6932 ModifyNewCoins saves database lookups #7056 Save last db read