0.10 regression: genbuild.sh tries to mess with files outside non-git source root #5902

issue luke-jr opened this issue on March 14, 2015

luke-jr commented at 8:24 PM on March 14, 2015: member

Regression introduced by #4946

git rev-parse assumes there is a valid git repository (and --is-inside-work-tree only tells you if you're inside the work tree of it), but the conditional replaced was intended to determine if there was a git repository. As a result, building from the source tarballs means genbuild.sh tries to look for .git in directories about the root source directory.

Downstream Gentoo issue: https://bugs.gentoo.org/show_bug.cgi?id=476294
theuni commented at 5:23 AM on March 17, 2015: member

Will have a look, thanks for reporting.
laanwj added the label Build system on Mar 18, 2015
laanwj commented at 11:10 AM on December 3, 2015: member

Is this fixed?
laanwj commented at 4:07 PM on February 9, 2016: member

Closing due to inactivity
laanwj closed this on Feb 9, 2016
Flowdalic referenced this in commit a76d15cfba on Feb 10, 2016
Flowdalic cross-referenced this on Feb 10, 2016 from issue Make genbuild.sh check for '.git' by Flowdalic
bitcoin locked this on Sep 8, 2021

Contributors

Labels