Reinitialize state in between individual unit tests. #5852

pull sipa wants to merge 1 commits into bitcoin:master from sipa:testreset changing 14 files +124 −61

sipa commented at 4:36 PM on March 3, 2015: member

No description provided.
sipa force-pushed on Mar 3, 2015
sipa commented at 4:54 PM on March 3, 2015: member

Tested with valgrind: zero memory leaks in test_bitcoin.
laanwj added the label Tests on Mar 3, 2015

Reinitialize state in between individual unit tests.

This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.

51598b2631

sipa force-pushed on Mar 3, 2015
sipa commented at 5:02 PM on March 3, 2015: member

@gavinandresen ping
gavinandresen commented at 5:05 PM on March 3, 2015: contributor

Code review ACK-- very nice!

I'll re-implement the #5835 unit test on top of this after lunch, to test.
gavinandresen commented at 8:15 PM on March 4, 2015: contributor

ACK. Tested by reimplementing unit test of #5835 with a REGTEST-mode 100-block chain.
laanwj commented at 11:43 AM on March 9, 2015: member

utACK
laanwj merged this on Mar 9, 2015
laanwj closed this on Mar 9, 2015
laanwj referenced this in commit cdae53e456 on Mar 9, 2015
Warrows cross-referenced this on Jan 31, 2019 from issue Bring PIVX random on par with bitcoin by Warrows
Warrows cross-referenced this on Feb 3, 2019 from issue [Test] Create new per-test fixtures by Warrows
bitcoin locked this on Sep 8, 2021

Contributors

Labels