refactor: move BDB (bitdb / db.h) interaction from init.cpp to wallet.cpp #5758

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/02/wallet_refactoring changing 3 files +72 −44

jonasschnelli commented at 8:21 PM on February 4, 2015: contributor

this will remove db.h from init.cpp
jonasschnelli cross-referenced this on Feb 5, 2015 from issue [Wallet] improve/replace wallet by jonasschnelli
jonasschnelli cross-referenced this on Feb 6, 2015 from issue [Wallet] replace BDB with internal append only (logdb) backend by jonasschnelli
jtimon commented at 7:21 PM on February 6, 2015: contributor

ut ACK
laanwj added the label Improvement on Feb 19, 2015
arnuschky cross-referenced this on Feb 20, 2015 from issue [Wallet] Wallet-pruning by cozz
jgarzik commented at 2:03 PM on March 11, 2015: contributor

ut ACK
laanwj commented at 9:37 AM on March 18, 2015: member

Nice! Going to test.
refactor: move bdb (bitdb) interaction from init.cpp to wallet.cpp
this will remove db.h from init.cpp
2578975312
in src/init.cpp:None in 4d64d99e82 outdated
```
 873 | -                InitWarning(msg);
 874 | -            }
 875 | -            if (r == CDBEnv::RECOVER_FAIL)
 876 | -                return InitError(_("wallet.dat corrupt, salvage failed"));
 877 | -        }
 878 | +        string warningString;
```
laanwj commented at 9:42 AM on March 18, 2015:

Nit: please use std::string. We'd like to get rid of the global using namespaces at some point.

jonasschnelli commented at 1:14 PM on March 18, 2015:

Okay. Updated. There are multiple string instantiations without the std:: namespace within init.cpp. I don't touch these (as well as the one i code-moved) for now.
jonasschnelli force-pushed on Mar 18, 2015
laanwj referenced this in commit f3948a30cd on Mar 20, 2015
laanwj commented at 3:31 PM on March 20, 2015: member

Merged via 2bb1c87700a80f0b20b4b2cbd68a0d82a18dbcc0 (trivial header conflict fixed)
laanwj closed this on Mar 20, 2015
Warrows referenced this in commit 73f711cc2c on Oct 14, 2019
Warrows referenced this in commit 7b441e53a4 on Nov 23, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5389 [Wallet] Wallet-pruning #5686 [Wallet] replace BDB with internal append only (logdb) backend #5761 [Wallet] improve/replace wallet