fix crash: CoinControl "space" bug #5700

pull fsb4000 wants to merge 1 commits into bitcoin:master from fsb4000:patch-1 changing 1 files +3 −2
  1. fsb4000 commented at 2:14 PM on January 23, 2015: contributor

    Bug description:

    1. Run Bitcoin-Qt
    2. Open CoinControl
    3. Click mouse here(Don't select any input) here
    4. Press "space"
    5. Result result

    Fix: this->currentItem() returns the current item in the tree widget and NULL if no selected items. So we don't try setCheckState for NULL.

    As https://github.com/novacoin-project/novacoin/commit/baf80c26a2e7f1ba6061d63d174eff0a09111e6f https://github.com/novacoin-project/novacoin/pull/120

  2. fix crash: CoinControl "space" bug
    Just like https://github.com/novacoin-project/novacoin/commit/baf80c26a2e7f1ba6061d63d174eff0a09111e6f
    0eade74c78
  3. fanquake commented at 2:31 PM on January 23, 2015: member

    Recreated the bug, and the provided patch does indeed fix the behaviour. ACK

  4. jonasschnelli commented at 3:03 PM on January 23, 2015: contributor
  5. laanwj commented at 3:06 PM on January 23, 2015: member

    Thanks, good catch

  6. laanwj added this to the milestone 0.10.0 on Jan 23, 2015
  7. laanwj added the label GUI on Jan 23, 2015
  8. laanwj added the label Priority High on Jan 23, 2015
  9. laanwj merged this on Jan 23, 2015
  10. laanwj closed this on Jan 23, 2015

  11. laanwj referenced this in commit b6acd4563d on Jan 23, 2015
  12. laanwj referenced this in commit ed4206acb1 on Jan 23, 2015
  13. sandakersmann cross-referenced this on Jan 26, 2015 from issue Fix crash: CoinControl "space" bug by sandakersmann
  14. UdjinM6 cross-referenced this on Jan 30, 2015 from issue fix coin control crash by UdjinM6
  15. fsb4000 cross-referenced this on Feb 2, 2015 from issue CoinControl "space" bug by fsb4000
  16. fsb4000 deleted the branch on Feb 8, 2015
  17. jyap808 referenced this in commit 066fe32918 on Sep 14, 2015
  18. glv2 referenced this in commit 8f12a5e5ea on Mar 22, 2016
  19. sigmike referenced this in commit 8f9a4f18c3 on Jun 17, 2017
  20. Astrych referenced this in commit b508b601db on Dec 18, 2018
  21. Astrych referenced this in commit a50407d9cf on Jan 16, 2019
  22. reddink referenced this in commit f21803f3c6 on May 27, 2020
  23. bitcoin locked this on Sep 8, 2021
Labels

Milestone
0.10.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC