Increase block download timeout base from 10 to 20 minutes. #5647

1. 
   gmaxwell commented at 6:03 PM on January 12, 2015: contributor

   This harmonizes the block fetch timeout with the existing ping timeout and eliminates a guaranteed eventual failure from congestion collapse for a network operating right at its limit.

   It's unlikely that we wouldn't suffer other failures if we were really anywhere near the network's limit, and a complete avoidance of congestion collapse risk requires (I think) an exponential back-off. So this isn't a major concern, but I think it's also useful for reducing the complexity of understanding out timeouts.

2. 
   Diapolo commented at 6:49 PM on January 12, 2015: none

   Nit: the timeout the existing ping timeout ;).

3. Increase block download timeout base from 10 to 20 minutes.

   This harmonizes the block fetch timeout with the existing ping timeout
    and eliminates a guaranteed eventual failure from congestion collapse
    for a network operating right at its limit.
   
   It's unlikely that we wouldn't suffer other failures if we were really
    anywhere near the network's limit, and a complete avoidance of congestion
    collapse risk requires (I think) an exponential back-off. So this isn't
    a major concern, but I think it's also useful for reducing the complexity
    of understanding out timeouts.

   3ff735c99a
4. 
   gmaxwell commented at 4:18 PM on January 13, 2015: contributor

   @Diapolo fixed.

5. laanwj added the label RPC on Jan 14, 2015
6. laanwj removed the label RPC on Jan 14, 2015
7. laanwj added the label P2P on Jan 14, 2015
8. laanwj added the label Priority High on Jan 14, 2015
9. ajweiss cross-referenced this on Jan 14, 2015 from issue node blockHeight stuck at 338832 by jlopp
10. 
    laanwj commented at 4:37 PM on January 20, 2015: member

    Maybe we should bind this to a constant. If the ping timeout changes, this should too?

11. laanwj added this to the milestone 0.10.0 on Jan 23, 2015
12. laanwj merged this on Feb 3, 2015
13. laanwj closed this on Feb 3, 2015

    ---

14. laanwj referenced this in commit 6ee87f9bc5 on Feb 3, 2015
15. laanwj referenced this in commit 1eb14af28f on Feb 3, 2015
16. reddink referenced this in commit 782ed729dd on Jul 11, 2020
17. reddink referenced this in commit 1244c7ce9d on Jul 14, 2020
18. bitcoin locked this on Sep 8, 2021

Contributors

gmaxwellDiapololaanwj

Milestone
0.10.0