Confusing MAX_TX_SIGOPS definition #5555

issue SergioDemianLerner opened this issue on December 28, 2014
  1. SergioDemianLerner commented at 3:57 PM on December 28, 2014: contributor

    MAX_TX_SIGOPS limit is a tx standard forwarding rule, not part of the consensus. The name suggests it is part of the consensus (as MAX_BLOCK_SIGOPS, which it is). It should be renamed to MAX_STANDARD_TX_SIGOPS. Also this comment in main.cpp: // Check that the transaction doesn't have an excessive number of // sigops, making it impossible to mine. Since the coinbase transaction // itself can contain sigops MAX_TX_SIGOPS is less than // MAX_BLOCK_SIGOPS; we still consider this an invalid rather than // merely non-standard transaction.

    is confusing, because it's perfectly possible to mine a transaction with MAX_TX_SIGOPS sigops.

  2. luke-jr cross-referenced this on Jan 1, 2015 from issue Rename MAX_TX_SIGOPS to MAX_STANDARD_TX_SIGOPS to match similar policy constant MAX_STANDARD_TX_SIZE by luke-jr
  3. fanquake commented at 11:39 AM on January 8, 2015: member

    Can be closed now that #5589 is merged.

  4. laanwj closed this on Jan 8, 2015

  5. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC