remove sig_canonical.json and sig_noncanonical.json #5491

pull maraoz wants to merge 1 commits into bitcoin:master from maraoz:remove/sig_canonical.json changing 3 files +0 −31
  1. maraoz commented at 7:29 PM on December 16, 2014: contributor

    I noticed this two files are not used by any tests. Discussed with @sipa on IRC and he said the files could be removed. Apparently the conditions those fixtures test for are now in script tests. Can someone else check this to be sure?

  2. remove sig_canonical.json and sig_noncanonical.json d1e243acea
  3. sipa commented at 9:58 PM on December 16, 2014: member

    They were removed in #5004. See that PR for details.

  4. laanwj commented at 4:26 PM on December 17, 2014: member

    ACK.

  5. fanquake commented at 3:38 AM on December 19, 2014: member

    ACK

  6. Diapolo commented at 7:23 AM on December 19, 2014: none

    ACK

  7. fanquake cross-referenced this on Jan 3, 2015 from issue Canonical signature tests contain an invalid signature by davecgh
  8. laanwj added the label Trivial on Jan 8, 2015
  9. laanwj commented at 10:15 AM on January 16, 2015: member

    This was merged into the @theuni's trivial branch, will be merged as part of it. https://github.com/theuni/bitcoin-trivial/commits/trivial-rebase

  10. laanwj closed this on Jan 16, 2015

  11. laanwj cross-referenced this on Feb 1, 2015 from issue Trivial tree merge by theuni
  12. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC