Check for available funds before call to SendMoney. #5393

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:insufffunds changing 1 files +4 −0

paveljanik commented at 10:09 AM on November 29, 2014: contributor
RPC call sendtoaddress doesn't check for available funds before the call to SendMoney. This results in suboptimal RPC error code returned. RPC_WALLET_ERROR (-4) instead of RPC_WALLET_INSUFFICIENT_FUNDS (-6):
```
# Before:
pavel$ ./bitcoin-cli sendtoaddress m...address... 1000
error: {"code":-4,"message":"Insufficient funds"}
# After:
pavel$ ./bitcoin-cli sendtoaddress m...address... 1000
error: {"code":-6,"message":"Insufficient funds"}
```
This fixes issue #3007.
Check for available funds before call to SendMoney. 8bb724740c
laanwj added the label Wallet on Dec 1, 2014
laanwj commented at 11:43 AM on December 1, 2014: member

This would work, although I'd prefer a deeper overhaul of SendMoney where it returns a status code instead of (or as well as) a string. Note that SendMoney is only used in the RPC interface (the GUI uses CreateTransaction/CommitTransaction), so you could move the function to rpcwallet.cpp and make it return a RPC status code as well.

BTW unrelated but looking at the function it makes no sense that the error messages returned over RPC are translated using _().
paveljanik commented at 1:36 PM on December 1, 2014: contributor

Can do that. But not for 0.10 IMO. For 0.10 I think the current branch and removing _() should be done (I can do that even in this branch). OK?
paveljanik cross-referenced this on Dec 1, 2014 from issue Move SendMoney() to rpcwallet.cpp. by paveljanik
laanwj commented at 3:02 PM on December 2, 2014: member

Closing in favor of #5399
laanwj closed this on Dec 2, 2014
paveljanik deleted the branch on Dec 2, 2014
bitcoin locked this on Sep 8, 2021

Contributors

paveljanik

laanwj

Labels

Wallet

Linked (view graph)

#3007 sendtoaddress() returns wrong error code for message 'Insufficient funds'#5399 Move SendMoney() to rpcwallet.cpp.