[REST] make selection of output-format mandatory, support dot url syntax #5376

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:rest-format-options changing 1 files +57 −32

jonasschnelli commented at 1:24 PM on November 26, 2014: contributor
1. Remove the default format (binary) because rest/block/<hash>/Hex would end up delivering binary data.
2. List available formats when chosen format was not found (reduces need for documentation)
3. Change url syntax to extension like format chosing (like rest/tx/<hash>.json (as originally mentioned in #2844)
jonasschnelli force-pushed on Nov 26, 2014
laanwj added this to the milestone 0.10.0 on Nov 27, 2014
sipa commented at 10:30 AM on November 27, 2014: member

Concept ACK, but I wouldn't do the case insensitivity. That just means more combinations to support in the future.

Also, coding style (spaces after if etc).
laanwj commented at 10:58 AM on November 27, 2014: member

Agree with sipa. Please don't leave any wiggling room in the REST API. Aliasing is generally bad, for example with regard to webcaches and such. One URL should map to one query.
jonasschnelli force-pushed on Nov 27, 2014
jonasschnelli commented at 12:17 PM on November 27, 2014: contributor

Agreed. It was a stupid idea to support uppercase/mixed-case URIs. Just removed the toLowercase transition. I also fixed the coding style (nit me if i didn't do it proper).
laanwj commented at 12:21 PM on November 27, 2014: member

utACK
jonasschnelli cross-referenced this on Nov 27, 2014 from issue [REST] Post-Merge overhaul of the REST API by jonasschnelli
jonasschnelli force-pushed on Nov 27, 2014
jonasschnelli force-pushed on Nov 27, 2014
jonasschnelli commented at 1:05 PM on November 27, 2014: contributor

Update coding style by auto.-reformatting with the src/.clang-format file. Tell me if there are still uncommon formatting.
jonasschnelli force-pushed on Nov 27, 2014
laanwj commented at 1:06 PM on November 27, 2014: member

Looks good to me now.

[REST] make selection of output-format mandatory, support dot url syntax

1. Remove the default format (binary) because `rest/block/<hash>/Hex` would end up delivering binary data.
2. List available formats when chosen format was not found (reduces need for documentation)
3. Change url syntax to dot extension like format chosing (like `rest/tx/<hash>.json`

8a5c9513ba

jonasschnelli force-pushed on Nov 27, 2014
jgarzik commented at 1:11 PM on November 27, 2014: contributor

Looks good, will test
laanwj added the label RPC on Nov 28, 2014
sipa commented at 3:03 PM on November 28, 2014: member

Slightly tested ACK
laanwj merged this on Dec 2, 2014
laanwj closed this on Dec 2, 2014
laanwj referenced this in commit fec0d100d5 on Dec 2, 2014
laanwj referenced this in commit 90f7aa7778 on Dec 2, 2014
reddink referenced this in commit 527b113237 on May 27, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Milestone
0.10.0

Linked (view graph)

#2844 Add unauthenticated HTTP REST interface #5326 [REST] Post-Merge overhaul of the REST API