Previously bitrpc was returning generic errors. I threw in a raise which provides useful info. @laanwj mentioned it wouldn't be a good idea to raise after catching the exception. And so I changed it. Apologies for opening a new PR instead of updating the existing one.
print the caught error instead of raising an error #5360
pull heath wants to merge 1 commits into bitcoin:master from heath:fix/useful-errors-for-bitrpc changing 1 files +71 −73-
heath commented at 6:38 PM on November 24, 2014: contributor
-
print the caught error instead of raising an error 71acb86540
-
- heath cross-referenced this on Nov 24, 2014 from issue return useful information about encountered errors by heath
- laanwj added the label Docs and Output on Dec 2, 2014
-
laanwj commented at 3:19 PM on December 2, 2014: member
Slightly tested ACK.
BTW unrelated to this pull, this script is a pain to set up and is a mess.
- Doesn't support testnet by default
- Doesn't read bitcoin.conf files - needs user/pass to be provided in text of program itself encouraging accidental committing
- There's lot of repitition.
- Should use AuthServiceProxy that is included in the tree instead of having a dependency on a 'jsonrpc' module
Anyone volunteering to give this a overhaul? Or would it be better to just remove it? Main argument I've heard for including this is that entering the
walletpassphraseon the command line is safer than passing it as argument to bitcoin-cli, but this is not exactly convenient to use. - laanwj merged this on Mar 18, 2015
- laanwj closed this on Mar 18, 2015
- laanwj referenced this in commit 29fef0b903 on Mar 18, 2015
- casey cross-referenced this on Aug 3, 2015 from issue Removed contrib/bitrpc by casey
- bitcoin locked this on Sep 8, 2021
Labels