qt: Reduce cs_main locking in GUI thread #5168

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_10_walletmodel_transaction_locking changing 5 files +159 −110

laanwj commented at 8:34 AM on October 29, 2014: member
- Do wallet transaction preprocessing on signal handler side (where the lock is still held); avoids locking cs_main/cs_wallet on notification in GUI thread (except for new transactions, for now)
- Move transaction new/update notification to TransactionTableModel. This moves the concerns to where they're actually handled. No need to bounce this through wallet model.
(improves #5037)

qt: Move transaction notification to transaction table model

Move transaction new/update notification to TransactionTableModel.
This moves the concerns to where they're actually handled.
No need to bounce this through wallet model.

- Do wallet transaction preprocessing on signal handler side;
  avoids locking cs_main/cs_wallet on notification in GUI thread
  (except for new transactions)

023e63df78

laanwj added the label GUI on Oct 29, 2014
laanwj added the label Wallet on Oct 29, 2014
laanwj cross-referenced this on Oct 29, 2014 from issue bitcoin-qt keeps freezing every ~10 seconds by rebroad
cozz commented at 7:48 PM on October 29, 2014: contributor

works for me
laanwj merged this on Oct 31, 2014
laanwj closed this on Oct 31, 2014
laanwj referenced this in commit 7bb681d407 on Oct 31, 2014
bitcoin locked this on Sep 8, 2021

Contributors

laanwj

cozz

Labels

GUI Wallet

Linked (view graph)

#5037 bitcoin-qt keeps freezing every ~10 seconds