Only include undo.h from main.cpp #5111

pull jtimon wants to merge 5 commits into bitcoin:master from jtimon:core2 changing 7 files +104 −110

jtimon commented at 6:30 AM on October 21, 2014: contributor

Built on top of #5100. coins.o doesn't need to depend on undo.h (Decouple CCoins from CTxInUndo) miner.o neither (Decouple miner.o from CTxUndo) Finally, CBlockUndo can be moved from main.h to undo.h if it is first decoupled from CDiskBlockPos.
jtimon force-pushed on Oct 21, 2014
laanwj added the label Improvement on Oct 22, 2014
jtimon force-pushed on Oct 23, 2014
jtimon force-pushed on Oct 27, 2014
jtimon renamed this:
~~Decouple CCoins from CTxInUndo~~
Only include undo.h from main.cpp
on Oct 27, 2014
jtimon cross-referenced this on Oct 27, 2014 from issue MOVEONLY: Split Transaction and Block from core by jtimon
jtimon force-pushed on Oct 28, 2014
jtimon commented at 1:33 PM on October 28, 2014: contributor

Rebased to make it more readable.
sipa commented at 3:40 PM on October 29, 2014: member

utACK!
jtimon force-pushed on Oct 30, 2014
jtimon commented at 12:11 PM on October 30, 2014: contributor

Nits addressed.
sipa cross-referenced this on Nov 1, 2014 from issue Move some code to undo.cpp. by domob1812
sipa commented at 1:35 PM on November 4, 2014: member

Needs rebase.
jtimon force-pushed on Nov 5, 2014
jtimon commented at 10:42 AM on November 5, 2014: contributor

Rebased and squashed the commits solving the nits.
sipa commented at 2:08 PM on November 18, 2014: member

utACK still
jtimon force-pushed on Nov 21, 2014
jtimon commented at 2:47 PM on November 21, 2014: contributor

Needed rebase for the doxygen comments.
jtimon force-pushed on Dec 2, 2014
jtimon commented at 10:46 PM on December 2, 2014: contributor

Rebased adding @theuni 's suggestions.

in src/main.cpp:None in 3e5c96b106 outdated

1508 | +    CHashWriter hasher(SER_GETHASH, PROTOCOL_VERSION);
1509 | +    hasher << hashBlock;
1510 | +    hasher << blockundo;
1511 | +    fileout << hasher.GetHash();
1512 | +
1513 | +    // Flush stdio buffers and commit to disk before returning

sipa commented at 11:11 PM on December 2, 2014:

This part was removed in head.

jtimon force-pushed on Dec 2, 2014
jtimon commented at 11:40 PM on December 2, 2014: contributor

Sorry, mistake rebasing...
jtimon force-pushed on Dec 9, 2014
jtimon commented at 3:29 PM on December 9, 2014: contributor

Rebased
jtimon force-pushed on Dec 9, 2014
Decouple CCoins from CTxInUndo c444c620c6
Decouple miner.o and txmempool.o from CTxUndo d7621ccf9d
Decouple CBlockUndo from CDiskBlockPos e035c6a737
MOVEONLY: CBlockUndo from main.h to undo.h 937ba572d0
Move UndoWriteToDisk() and UndoReadFromDisk() to anon namespace 87fb31086d
jtimon force-pushed on Dec 27, 2014
jtimon commented at 3:03 PM on December 27, 2014: contributor

Rebased again. Like miner.cpp, txmempool.cpp was now also unnecessarily coupled with CTxUndo.
jgarzik commented at 11:49 AM on December 31, 2014: contributor

ACK
jgarzik merged this on Dec 31, 2014
jgarzik closed this on Dec 31, 2014
jgarzik referenced this in commit aa5c0d34b7 on Dec 31, 2014
random-zebra cross-referenced this on Jul 13, 2020 from issue [Core] Only include undo.h from main.cpp by random-zebra
furszy referenced this in commit 128978d45b on Jul 16, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5100 MOVEONLY: Split Transaction and Block from core #5192 Move some code to undo.cpp.