Bugfix: CreateNewBlock and miner_tests: Also check generated template is valid by other validity factors #5103

pull luke-jr wants to merge 4 commits into bitcoin:master from luke-jr:bugfix_mining_tests changing 4 files +108 −61
  1. luke-jr commented at 1:48 AM on October 20, 2014: member

    Originally, ConnectBlock did all the validity tests over. Now, it doesn't, so to test a block template we need to call the others manually.

  2. luke-jr cross-referenced this on Oct 30, 2014 from issue Support for BIP 23 block proposal by luke-jr
  3. luke-jr force-pushed on Oct 30, 2014
  4. luke-jr force-pushed on Oct 30, 2014
  5. luke-jr force-pushed on Oct 30, 2014
  6. luke-jr force-pushed on Oct 30, 2014
  7. luke-jr force-pushed on Nov 4, 2014
  8. luke-jr renamed this:
    CreateNewBlock and miner_tests: Also check generated template is valid by other validity factors
    Bugfix: CreateNewBlock and miner_tests: Also check generated template is valid by other validity factors
    on Nov 6, 2014
  9. Abstract context-dependent block checking from acceptance a48f2d6ddd
  10. CreateNewBlock and miner_tests: Also check generated template is valid by CheckBlockHeader, ContextualCheckBlockHeader, CheckBlock, and ContextualCheckBlock 4ea1be7fb8
  11. TestBlockValidity function for CBlock proposals (used by CreateNewBlock) df08a626e0
  12. miner_tests: Disable checkpoints so they don't fail the subsidy-change test 132ea9b48f
  13. luke-jr force-pushed on Nov 20, 2014
  14. laanwj merged this on Nov 24, 2014
  15. laanwj closed this on Nov 24, 2014
  16. bitcoin locked this on Sep 8, 2021
Contributors
luke-jr
Linked (view graph)
#1816 Support for BIP 23 block proposal
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC