Add IsNull() to class CAutoFile and remove operator ! #5089

pull rdponticelli wants to merge 1 commits into bitcoin:master from Criptomonedas:cautofileisnull changing 3 files +7 −7

rdponticelli commented at 3:51 AM on October 16, 2014: contributor

As suggested by @TheBlueMatt and @laanwj in #4701.

in src/serialize.h:None in 6d7580aa6f outdated

1121 | @@ -1122,8 +1122,7 @@ class CAutoFile
1122 |      FILE& operator*()           { return *file; }
1123 |      FILE** operator&()          { return &file; }
1124 |      FILE* operator=(FILE* pnew) { return file = pnew; }
1125 | -    bool operator!()            { return (file == NULL); }
1126 | -
1127 | +    bool IsNull() const         { return (file == 0); }

sipa commented at 5:39 AM on October 16, 2014:

Can you use NULL instead?

TheBlueMatt commented at 5:51 AM on October 16, 2014: contributor

utACK
laanwj commented at 6:39 AM on October 16, 2014: member

~~utACK~~ Edit: taking away my ACK for now, this will work but it doesn't cover all uses of !CAutoFile()
Add IsNull() to class CAutoFile and remove operator ! 8769d9e82c
rdponticelli force-pushed on Oct 16, 2014
laanwj cross-referenced this on Oct 20, 2014 from issue CAutoFile: Explicit Get(), IsNull() and remove unused methods by laanwj
laanwj commented at 10:57 AM on October 20, 2014: member

See #5108
rdponticelli closed this on Oct 20, 2014
bitcoin locked this on Sep 8, 2021

Contributors

Linked (view graph)

#4701 Autoprune #5108 CAutoFile: Explicit Get(), IsNull() and remove unused methods