Small improvements on a couple of debug messages #5017

pull jtimon wants to merge 2 commits into bitcoin:master from jtimon:debug_maaku changing 1 files +4 −2

jtimon commented at 11:50 PM on September 30, 2014: contributor

Taking a little bit of @maaku's work on Freicoin back to Bitcoin.

in src/main.cpp:None in 00000a5eed outdated

1360 | @@ -1361,7 +1361,8 @@ bool CheckInputs(const CTransaction& tx, CValidationState &state, const CCoinsVi
1361 |          }
1362 |  
1363 |          if (nValueIn < tx.GetValueOut())
1364 | -            return state.DoS(100, error("CheckInputs() : %s value in < value out", tx.GetHash().ToString()),
1365 | +            return state.DoS(100, error("CheckInputs() : %s value in < value out (%s < %s)",
1366 | +                                        tx.GetHash().ToString(), FormatMoney(nValueIn), FormatMoney(tx.GetValueOut())),

TheBlueMatt commented at 11:52 PM on September 30, 2014:

Can you do "%s value in (%s) < value out (%s)"?

laanwj commented at 1:11 PM on October 1, 2014: member

main.cpp: In function ‘bool CheckInputs(const CTransaction&, CValidationState&, const CCoinsViewCache&, bool, unsigned int, std::vector<CScriptCheck>*)’:

main.cpp:1365:86: error: ‘FormatMoney’ was not declared in this scope

When transaction outputs exceed inputs, show the offending amounts so as to aid debugging. 217a5c9238
Print input index when signature validation fails, to aid debugging. f74fc9b22d
jtimon force-pushed on Oct 1, 2014
jtimon commented at 6:11 PM on October 1, 2014: contributor

Fixed @TheBlueMatt 's nit and compile error.
TheBlueMatt commented at 8:53 PM on October 1, 2014: contributor

utACK
sipa commented at 2:06 AM on October 2, 2014: member

utACK
laanwj merged this on Oct 2, 2014
laanwj closed this on Oct 2, 2014
laanwj referenced this in commit 00eef5d6e9 on Oct 2, 2014
laanwj cross-referenced this on Oct 2, 2014 from issue Make signature caching optional, and move it out. by sipa
bitcoin locked this on Sep 8, 2021

Contributors

Linked (view graph)

#4890 Make signature caching optional, and move it out.