'(' and ')' are valid in user agent strings, so should be reported as such in RPC getpeerinfo.
Fixes #4537.
SanitizeString: allow '(' and ')' #4983
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_09_safechars_bip0014 changing 1 files +1 −1-
laanwj commented at 10:46 AM on September 25, 2014: member
-
d14d7deff0
SanitizeString: allow '(' and ')'
'(' and ')' are valid in user agent strings, so should be reported as such in RPC `getpeerinfo`. Fixes #4537. -
BitcoinPullTester commented at 11:00 AM on September 25, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4983_d14d7deff0a93d81946abec671dc47c967c9b027/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 11:40 AM on September 25, 2014: none
ACK
-
sipa commented at 5:35 PM on September 26, 2014: member
ACK
- sipa merged this on Sep 26, 2014
- sipa closed this on Sep 26, 2014
- sipa referenced this in commit 610a3d3a1b on Sep 26, 2014
- MarcoFalke cross-referenced this on Sep 23, 2015 from issue SanitizeString: Allow hypen char by MarcoFalke
- luke-jr cross-referenced this on Jul 6, 2017 from issue Escape rather than remove any printable characters in UAs by luke-jr
- bitcoin locked this on Sep 8, 2021
