When pos is at the last element of the in vector executing line 34 creates index pointing outside of in. To prevent access violation new check is required at line 35.
Fixing out of bounds access error in crypto_tests #4966
pull ENikS wants to merge 1 commits into bitcoin:master from ENikS:crypto_test_fix changing 1 files +1 −1-
ENikS commented at 3:23 PM on September 23, 2014: contributor
-
Fixing out of bounds asses error c8063b5712
- ENikS renamed this:
Fixing out of bounds asses error
Fixing out of bounds asses error in crypto_tests
on Sep 23, 2014 - ENikS renamed this:
Fixing out of bounds asses error in crypto_tests
Fixing out of bounds access error in crypto_tests
on Sep 23, 2014 -
BitcoinPullTester commented at 3:37 PM on September 23, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4966_c8063b57124600ae4e8e2a65eab402d3c47babe2/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
sipa commented at 6:28 PM on September 23, 2014: member
ACK
- theuni cross-referenced this on Sep 24, 2014 from issue Debug depends/stl by theuni
- laanwj merged this on Sep 25, 2014
- laanwj closed this on Sep 25, 2014
- laanwj referenced this in commit 29a9d4483e on Sep 25, 2014
- ENikS deleted the branch on Sep 25, 2014
- bitcoin locked this on Sep 8, 2021
Contributors
Linked (view graph)