#3514 changed the time used with askfors from seconds to milliseconds but the change introduced an assumption that the time needed to be reduced by 1 second, when it fact it was the number that needed to be reduced by 1.
Only need to subtract 1 (originally time was in seconds). #4828
pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:AskforTime changing 1 files +1 −1-
rebroad commented at 3:52 AM on September 3, 2014: contributor
-
Only need to subtract 1 (originally time was in seconds). 469f440924
-
BitcoinPullTester commented at 4:15 AM on September 3, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4828_469f440924f120f34c6e065d236e8ca230456445/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
TheBlueMatt commented at 6:32 AM on September 3, 2014: contributor
Can you also add a comment to explain why the -1 is there to begin with?
-
rebroad commented at 6:46 AM on September 3, 2014: contributor
@TheBlueMatt I used to understand why the -1 was there long ago, but I've lost the memory of why it was needed now... I'd have to relook at the code from years ago to work it out.
- laanwj cross-referenced this on Sep 4, 2014 from issue net: Better askfor request management by laanwj
-
- laanwj closed this on Sep 10, 2014
- rebroad cross-referenced this on Mar 8, 2016 from issue Only need to subtract 1 (originally nNow was in seconds). by rebroad
- bitcoin locked this on Sep 8, 2021
