Use a typedef for monetary values #4614

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:typedef2 changing 58 files +354 −319

jtimon commented at 12:20 AM on August 1, 2014: contributor

Rebased and bike-shed version of #4234
Use a typedef for monetary values 0adf98ed38
jtimon cross-referenced this on Aug 1, 2014 from issue Use a typedef for monetary values by maaku
BitcoinPullTester commented at 12:34 AM on August 1, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4614_0adf98ed38c706ebae07a0d74bf6bab18e1b9f42/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
maaku commented at 2:52 AM on August 1, 2014: contributor

I updated the original PR.
laanwj commented at 7:22 AM on August 1, 2014: member

ACK (checked that it only changes type names using sipa's git show --word-diff-regex='[[:alnum:]]+|[^[:space:]])
laanwj added the label Improvement on Aug 1, 2014
gmaxwell commented at 10:20 PM on August 1, 2014: contributor

ACK. I like this, I generally prefer more specific typing.
bpay commented at 11:05 PM on August 1, 2014: contributor

Why the change to pass by const ref? For something that small you'll likely get better codegen just passing by value.
sipa commented at 11:10 PM on August 1, 2014: member

@bpay As long as CAmount is a simple type, yes.
maaku commented at 5:15 PM on August 2, 2014: contributor

Jorge, there's a number of locations in this pull request using int64 which have not been updated to use the new type. (Compare diffs with #4234, which is now properly rebased & updated.)
jtimon commented at 5:39 PM on August 2, 2014: contributor

Let's just merge #4234 then, I'm closing this one.
jtimon closed this on Aug 2, 2014
jtimon deleted the branch on Aug 11, 2014
sipa cross-referenced this on Dec 7, 2014 from issue CAmount: Small improvements related to CAmount by jtimon
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#4234 Use a typedef for monetary values #5430 CAmount: Small improvements related to CAmount