Refactor common RPC test code to BitcoinTestFramework base class #4485

pull gavinandresen wants to merge 2 commits into bitcoin:master from gavinandresen:refactor_python_tests changing 7 files +348 −505
  1. gavinandresen commented at 4:12 PM on July 8, 2014: contributor

    Inspired by #3956, with a little more flexibility built in.

    I didn't touch rpcbind_test.py, because it only runs on Linux.

  2. laanwj commented at 6:16 AM on July 9, 2014: member

    Code changes look good to me. ACK after pulltester happy.

  3. Refactor common RPC test code to BitcoinTestFramework base class
    Inspired by #3956, with a little more flexibility built in.
    
    I didn't touch rpcbind_test.py, because it only runs on Linux.
    e8097f7df1
  4. Print better errors, and add util stop_node() function. f5a92bf9bd
  5. BitcoinPullTester commented at 2:47 PM on July 9, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4485_f5a92bf9bd9e5547cb8b4c0084c7e23c36b49b70/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  6. gavinandresen commented at 3:34 PM on July 9, 2014: contributor

    FYI: pull-tester problem was just a random timeout failure (not going to bother trying to fix, since Cory is rewriting pull-tester).

  7. gavinandresen referenced this in commit f3330b40a5 on Jul 9, 2014
  8. gavinandresen merged this on Jul 9, 2014
  9. gavinandresen closed this on Jul 9, 2014

  10. dgenr8 cross-referenced this on Jul 13, 2014 from issue Set -discover=0 in regtest framework by dgenr8
  11. jonasschnelli cross-referenced this on Nov 18, 2015 from issue [qa] python-bitcoinrpc is no longer a subtree by MarcoFalke
  12. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC